← Back to issue list

snapcraft/plugins: Add gomod plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#2817
Type
pull request
State
closed
Author
mhilton
Labels
—
Created
Updated
Closed

Current evaluation

PR adding a standalone gomod plugin was closed unmerged on 2019-12-03 by sergiusens in favour of #2824, which added go module support to the existing Go plugin instead.

Resolution: closed superseded

Reason: Maintainer sergiusens commented 'Closing in favour of #2824' on 2019-12-03, noting the gomod work overlapped his own and that go modules should be part of the existing go plugin. #2824 was subsequently merged, delivering go.mod support (commit 1f609a357).

Evaluated by: mr-cal-bot

No scores available.

Issue body

New plugin for building go projects that use modules for dependency management. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR adding a standalone gomod plugin was closed unmerged on 2019-12-03 by sergiusens in favour of #2824, which added go module support to the existing Go plugin instead.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #2824, which merged go.mod support into the existing Go plugin via commit 1f609a357.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #2824, which added go.mod support to the existing Go plugin rather than introducing a separate gomod plugin.
qwen/qwen3.6-35b-a3b — — Closed in favor of #2824 after maintainer noted overlap with existing work. The gomod plugin was superseded by another PR addressing the same functionality.
qwen3.6-35b-a3b-mtp-q6 — — Proposed gomod plugin support was closed and superseded by #2824. Overlapping functionality with existing work prompted the maintainer to merge the changes into the referenced PR instead.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2824 (confidence 95%)

    Explicitly cited in the closing comment; merged PR adding go.mod support to the existing Go plugin rather than a new gomod plugin.

Related issues

Issue Project State Summary Similarity
#1879315 go plugin: go mod support @ golang 1.12 snapcraft (launchpad) closed Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning.
73%
#2824 Support for go.mod snapcraft merged Merged Go module support for Snapcraft’s Go plugin in commit 1f609a357; follow-up PRs expanded compatibility and package detection.
72%
#1802256 go plugin: support Go modules snapcraft (launchpad) closed Closed as done: Go module support landed in the successor craft-parts Go plugin (merged PR canonical/craft-parts#78, commit b5b779df), which builds from go.mod; maintainer mr-cal cited it when closing.
70%