← Back to issue list

Support for go.mod

View original Github issue

Metadata

Project
snapcraft
Number
#2824
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged Go module support for Snapcraft’s Go plugin in commit 1f609a357; follow-up PRs expanded compatibility and package detection.

Resolution: closed resolved

Reason: PR #2824 was approved and merged as commit 1f609a357, adding go.mod support. Follow-up PRs #2962 and #3133 later added nested-main-package handling and Go 1.11/1.12 compatibility.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged Go module support for Snapcraft’s Go plugin in commit 1f609a357; follow-up PRs expanded compatibility and package detection.
stealth/space-bunny-alpha — closed resolved Merged Go module support into Snapcraft’s Go plugin via commit 1f609a357.
stealth/space-bunny-alpha — closed resolved Added Go module support to Snapcraft’s Go plugin and merged the change in commit 1f609a357.
qwen/qwen3.6-35b-a3b — — Merged after approval, adding go.mod support across seven files. Author noted potential need to restore legacy binary name deduction logic to maintain compatibility with older Go versions.
qwen3.6-35b-a3b-mtp-q6 — — Merged to add go.mod support. Maintainer noted potential need to restore binary name deduction logic for older Go version compatibility.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2962 (confidence 96%)

    Follow-up fix for go.mod projects whose main package is outside the repository root.

  • Related To: canonical/snapcraft#3133 (confidence 96%)

    Follow-up adding go.mod support for Go 1.11 and 1.12 in the v1 plugin.

Related issues

Issue Project State Summary Similarity
#1879315 go plugin: go mod support @ golang 1.12 snapcraft (launchpad) closed Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning.
78%
#2817 snapcraft/plugins: Add gomod plugin. snapcraft closed PR adding a standalone gomod plugin was closed unmerged on 2019-12-03 by sergiusens in favour of #2824, which added go module support to the existing Go plugin instead.
72%
#1802256 go plugin: support Go modules snapcraft (launchpad) closed Closed as done: Go module support landed in the successor craft-parts Go plugin (merged PR canonical/craft-parts#78, commit b5b779df), which builds from go.mod; maintainer mr-cal cited it when closing.
71%
#3132 go v1 plugin: warn when using go.mod and go < 1.13 snapcraft closed Superseded by canonical/snapcraft#3133, merged as d9be0e925, which added Go 1.11/1.12 go.mod support and a one-time warning.
71%