lint: add shellcheck, yamllint
Metadata
Current evaluation
Merged PR #291 in commit 68ac1cc, adding shellcheck and yamllint from Starbase to address #287.
Resolution: closed resolved
Reason: PR #291 was merged as commit 68ac1cc, introducing shellcheck and yamllint linting and resolving its stated linting work for #287.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Add `shellcheck` and `yamllint` from starbase.
This builds on top of https://github.com/canonical/craft-providers/pull/289, so only the third commit needs review here.
See https://github.com/canonical/craft-providers/issues/287.
(CRAFT-1726)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #291 in commit 68ac1cc, adding shellcheck and yamllint from Starbase to address #287. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #291 as commit 68ac1cc, adding shellcheck and yamllint from Starbase and advancing the broader sync tracked by #287. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR #291 adding shellcheck and yamllint linting from starbase, addressing issue #287. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
canonical/craft-providers#287
(confidence 100%)
The pull request explicitly identifies #287 as the issue addressed.
-
Related To:
canonical/craft-providers#289
(confidence 98%)
The pull request says it builds on #289 and isolates the final commit for review.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #11 tools: add yamllint | starbase | merged | Merged PR canonical/starbase#11 as commit 5a0d09f, adding optional yamllint tooling and configuration across three files. | |
| #196 lint: add shellcheck and spread-shellcheck linters | rockcraft | merged | Merged PR #196 as b7c4c794, adding ShellCheck and spread-shellcheck to GitHub CI plus minor compliance fixes. | |
| #144 build(deps): remove yamllint | craft-platforms | merged | Merged PR #144 removed yamllint and updated the pre-commit configuration from Starbase in commit 35b75fc. | |
| #14 chore(ci): add shellcheck and yamllint | snapcraft-rocks | merged | Merged canonical/snapcraft-rocks#14, adding ShellCheck and yamllint to CI and resolving issue #9. | |
| #9 lint spread tests with shellcheck | snapcraft-rocks | closed | Added ShellCheck linting for spread tests via merged PR canonical/snapcraft-rocks#14 ("chore(ci): add shellcheck and yamllint"), which also enabled yamllint. Maintainer tigarmo closed the issue with "Fixed by #14". | |
| #201 lint: run shellcheck on spread.yaml | rockcraft | merged | Merged PR #201 in commit c90598eb, enabling ShellCheck linting for spread.yaml through a small lint-configuration update. | |
| #305 style: replace yamllint with prettier | starbase | merged | Merged PR canonical/starbase#305 (commit 68d8d79, CRAFT-3626) swapped yamllint for Prettier in pre-commit and common.mk, covering YAML, JSON, JSON5, CSS and Markdown; TOML excluded pending prettier/prettier#15141. Closes #273. | |
| #286 ci: sync configs with starbase | craft-providers | merged | Merged PR #286 as commit 73c340c, syncing .gitignore, .editorconfig, and yamllint.yaml with Starbase as the first configuration synchronization. | |
| #1421 build: enable yamllint | charmcraft | merged | Merged PR #1421 in commit 4f9aa82b, enabling yamllint in Charmcraft's build checks and configuration. |