lint spread tests with shellcheck
Metadata
Current evaluation
Added ShellCheck linting for spread tests via merged PR canonical/snapcraft-rocks#14 ("chore(ci): add shellcheck and yamllint"), which also enabled yamllint. Maintainer tigarmo closed the issue with "Fixed by #14".
Resolution: closed resolved
Reason: PR #14 was merged, adding ShellCheck (and yamllint) to CI, and the issue was closed by maintainer tigarmo on 2024-02-27 with the comment "Fixed by #14", confirming the resolution.
Evaluated by: mr-cal-bot
No scores available.
Issue body
https://github.com/canonical/snapcraft-rocks/pull/6#discussion_r1449118867
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Added ShellCheck linting for spread tests via merged PR canonical/snapcraft-rocks#14 ("chore(ci): add shellcheck and yamllint"), which also enabled yamllint. Maintainer tigarmo closed the issue with "Fixed by #14". | |
| stealth/space-bunny-alpha | — | closed resolved | ShellCheck linting for spread tests was added to CI by merged PR canonical/snapcraft-rocks#14, which also enabled yamllint. The maintainer confirmed the issue was fixed by #14. | |
| stealth/space-bunny-alpha | — | closed resolved | ShellCheck linting for spread tests was added in merged PR canonical/snapcraft-rocks#14; the maintainer confirmed the issue was fixed by that PR. | |
| qwen/qwen3.6-35b-a3b | — | — | Shellcheck linting for spread tests was implemented via merged pull request #14. The issue is closed. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed by merging pull request #14. The maintainer confirmed shellcheck linting for spread tests was implemented and closed the issue on February 27, 2024. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by merging pull request #14, which applied shellcheck to lint the spread tests. The fix was confirmed by the maintainer on February 27, 2024. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by merging pull request #14, which applied shellcheck to lint the spread tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Fixed by PR #14, which added shellcheck linting to spread tests. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft-rocks#14
(confidence 96%)
Merged PR titled 'chore(ci): add shellcheck and yamllint'; the issue's only comment cites it as the fix.
-
Related To:
canonical/snapcraft-rocks#6
(confidence 72%)
Issue originated from a review comment on PR #6 (discussion_r1449118867), where the suggestion to shellcheck spread tests was raised.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #201 lint: run shellcheck on spread.yaml | rockcraft | merged | Merged PR #201 in commit c90598eb, enabling ShellCheck linting for spread.yaml through a small lint-configuration update. | |
| #196 lint: add shellcheck and spread-shellcheck linters | rockcraft | merged | Merged PR #196 as b7c4c794, adding ShellCheck and spread-shellcheck to GitHub CI plus minor compliance fixes. | |
| #14 chore(ci): add shellcheck and yamllint | snapcraft-rocks | merged | Merged canonical/snapcraft-rocks#14, adding ShellCheck and yamllint to CI and resolving issue #9. | |
| #2381 tools: copy in spread-shellcheck from snapd | snapcraft | merged | Merged PR #2381 as cce7842e8, adding snapd's spread-shellcheck tool, expanding ShellCheck coverage to spread tests, and correcting affected glob patterns. | |
| #291 lint: add shellcheck, yamllint | craft-providers | merged | Merged PR #291 in commit 68ac1cc, adding shellcheck and yamllint from Starbase to address #287. |