← Back to issue list

lint spread tests with shellcheck

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#9
Type
issue
State
closed
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Shellcheck linting for spread tests was implemented via merged pull request #14. The issue is closed.

Suggested action:

No scores available.

Issue body

https://github.com/canonical/snapcraft-rocks/pull/6#discussion_r1449118867

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Shellcheck linting for spread tests was implemented via merged pull request #14. The issue is closed.
qwen/qwen3.6-35b-a3b Fixed by merging pull request #14. The maintainer confirmed shellcheck linting for spread tests was implemented and closed the issue on February 27, 2024.
qwen/qwen3.6-35b-a3b Resolved by merging pull request #14, which applied shellcheck to lint the spread tests. The fix was confirmed by the maintainer on February 27, 2024.
qwen/qwen3.6-35b-a3b Resolved by merging pull request #14, which applied shellcheck to lint the spread tests.
qwen3.6-35b-a3b-mtp-q6 Fixed by PR #14, which added shellcheck linting to spread tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#201 lint: run shellcheck on spread.yaml rockcraft merged Pull request to run shellcheck on spread.yaml was approved, passed CI, and merged with a four-line change across two files.
83%
#196 lint: add shellcheck and spread-shellcheck linters rockcraft merged Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency.
79%
#2381 tools: copy in spread-shellcheck from snapd snapcraft merged Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions.
78%
#62 spread: add a "big" spread test rockcraft merged Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks.
75%
#665 Start using `spread` for integration tests charmcraft closed Completed and merged via pull request #862, which implemented the spread infrastructure and added integration tests. The issue was closed after the changes were successfully integrated.
72%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
72%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
72%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
70%