Needs Test for Git sources
Metadata
Current evaluation
Git-source unit coverage was added by canonical/snapcraft PR #233 and merged as f909dc292 (commit 106eb8e2d), resolving Launchpad #1534411.
Resolution: closed resolved
Reason: PR #233 added tests for Git sources in sources.py and was merged. The earlier unmerged PR #217 was reworked through this successor PR.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The tests for snapcraft/sources.py can be updated to include a test for Git sources
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Git-source unit coverage was added by canonical/snapcraft PR #233 and merged as f909dc292 (commit 106eb8e2d), resolving Launchpad #1534411. | |
| stealth/space-bunny-alpha | — | closed resolved | Git-source coverage was added to sources.py by PR #233, merged in f909dc292 with commit 106eb8e2d. | |
| qwen/qwen3.6-35b-a3b | — | — | Unit test coverage for Git sources in snapcraft/sources.py was never implemented. The request was closed without discussion or resolution, indicating it was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without action. The request to add unit tests for Git sources in snapcraft/sources.py was abandoned, with zero comments and no implementation. | |
| qwen/qwen3.6-35b-a3b | — | — | Request to add unit tests for Git sources in snapcraft/sources.py was closed without implementation. No comments or patches were submitted, indicating the request was abandoned due to prolonged inactivity. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Unit tests for Git sources in snapcraft/sources.py were never added. The request was closed without implementation or comments, indicating it was abandoned or superseded. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#233
(confidence 100%)
Merged PR that added Git-source unit-test coverage.
-
Related To:
canonical/snapcraft#217
(confidence 95%)
Closed without merging; its Git-source tests were reworked in PR #233.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #217 added test for git sources in the get() method in snapcraft/sources.py | snapcraft | closed | Closed unmerged; its Git-source tests were reworked and merged through successor PR #233 in commit f909dc292. | |
| #1137 Build-depend on git | snapcraft | merged | Merged in canonical/snapcraft#1137 (commit 8b3cb387d), adding git as a direct build dependency so Git source tests can invoke git. | |
| #233 added test for git sources in sources.py | snapcraft | merged | Merged PR adding unit tests for Git sources in sources.py. Reviewer questions on a pull() assertion were resolved as no-ops, and the PR was merged after approval. | |
| #216 Added test for sources.py | snapcraft | closed | Closed unmerged; its Git-source test was incorporated into merged #233 via commit 106eb8e2d (merge f909dc292). |