tests: completely mock subversion tests
Metadata
Current evaluation
Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour.
Resolution: closed resolved
Reason: The PR was approved and merged into master by maintainer sergiusens as commit 518083bb2, replacing real svn calls with mocks in the unit tests (+33/-44 across 3 files).
Evaluated by: mr-cal-bot
No scores available.
Issue body
This should speed them up, there are integration tests for ensuring
the rest.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2716 (commit 518083bb2) fully mocked Subversion tests to speed up execution while preserving integration coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master to accelerate test execution by fully mocking subversion tests. Approved by reviewers, passed CI, and caused a negligible 0.02% decrease in overall test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, this change completely mocks subversion tests to improve execution speed. The update was accepted despite a negligible 0.03% overall coverage decrease reported by Codecov. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4382 tests: use less mocks in remote-build | snapcraft | merged | PR #4382 merged (commit 906834cda): remote-build unit tests no longer mock snapcraft.yaml loading but write and load real project files, prep for #4322. | |
| #567 Add Subversion support | snapcraft | merged | Merged Subversion source support, tests, and packaging updates in canonical/snapcraft#567 (commit 0e1ec16e6), fixing Launchpad bug 1543243 and shipping in Snapcraft 2.12. | |
| #1652 tests: fork skip into snaps_tests | snapcraft | merged | PR #1652 (merged as commit c951a3679) forked a skipped test into snaps_tests to avoid overly broad snapcraft.tests imports that broke autopackage tests. | |
| #2713 tests: completely mock bzr tests | snapcraft | merged | PR #2713 by sergiusens was merged (commit d36264104, 'tests: completely mock bzr tests'), replacing real bzr invocations in the bzr source-plugin unit tests with mocks for speed, leaving coverage to integration tests. | |
| #1194 tests: remove repo.Ubuntu patch for plugins | snapcraft | merged | Merged in PR #1194 (commit 8d7b0ec63), removing obsolete plugin repo.Ubuntu test patches after stage-packages handling moved into Snapcraft core. | |
| #1651903 Plugin tests need to be reorganized | snapcraft (launchpad) | closed | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. |