← Back to issue list

lxd: pass through commands into the container

View original Github issue

Metadata

Project
snapcraft
Number
#1263
Type
pull request
State
merged
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1263 as commit e0f28bd5c, routing snap-building and parts commands through LXD containers so remote/cleanbuild commands run inside the container environment.

Resolution: closed resolved

Reason: The pull request was approved and merged into master as commit e0f28bd5c ("lxd: pass through commands into the container"), changing 5 files (+110/-96) to pass build/part commands into the LXD container. Follow-up work continued in #1372 and #1585.

Evaluated by: mr-cal-bot

No scores available.

Issue body

All commands around building snaps and dealing with parts will be passed through into the lxd container.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1263 as commit e0f28bd5c, routing snap-building and parts commands through LXD containers so remote/cleanbuild commands run inside the container environment.
stealth/space-bunny-alpha — closed resolved Merged #1263 as commit e0f28bd5c, passing snap-building and parts commands through LXD containers so remote builds execute inside the container environment.
stealth/space-bunny-alpha — closed resolved Merged PR #1263 in commit e0f28bd5c, passing snap-building and part-management commands into LXD containers for remote builds.
qwen/qwen3.6-35b-a3b — — Merged a pull request enabling snapcraft to pass build commands into LXD containers. The change allows remote builds to execute within the container environment, addressing path mounting issues during remote snap creation. Approved by one reviewer, though coverage decreased slightly.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. The PR enables passing snap build commands into LXD containers. A reviewer flagged a remote path mounting error, but the changes were approved and integrated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1585 (confidence 72%)

    Later merged PR extending this passthrough mechanism to forward SNAPCRAFT_PARTS_URI into the container, so cleanbuild can resolve remote parts.

  • Related To: canonical/snapcraft#1372 (confidence 70%)

    Follow-up merged PR fixing 'cli: Containerbuild clean' for SNAPCRAFT_CONTAINER_BUILDS=1, adding a unit test for the container build path touched here.

Related issues

Issue Project State Summary Similarity
#1585 lxd: pass SNAPCRAFT_PARTS_URI through into container snapcraft merged Merged in canonical/snapcraft#1585 (13ea598d5), forwarding SNAPCRAFT_PARTS_URI into LXD containers so cleanbuild can resolve remote parts; fixes Launchpad #1719951.
75%
#1364 lxd: Inject snapcraft and core snaps into the container snapcraft merged Merged PR #1364 as 99f5598ac, injecting the host's Snapcraft and core snaps into LXD containers so builds no longer use a mismatched Xenial archive version.
74%
#1627 lxd: split container classes into different files snapcraft merged Merged in snapcraft#1627 via d2118855c, splitting LXD container classes into separate modules, relocating Cleanbuilder methods and deduplicating environment setup without functional changes.
72%
#1644 lxd: fix the push in container builds snapcraft merged Merged PR #1644 fixed LXD container-build artifact pushes; the change landed as commit d4a34e07d.
72%
#328 New command cleanbuild (using lxd) snapcraft merged Merged via2f6116267 (branch feature/1480144/cleanbuild-lxd): adds the cleanbuild command building in LXD containers, dropping pylxd due to API/Python 3 breakage. Later fixes followed in #1610, #1807 and #2404.
72%
#1739 lxd: refresh remote container snapcraft merged Merged #1739 as 2f9265f23, fixing snapcraft refresh to honor the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of using a local container.
72%
#2222 lxd: support new style snap injection snapcraft merged Merged in #2222 via commit 8acd203, adding new-style LXD snap handling, removing sudo-based injection, and consolidating duplicated tests.
71%
#1230 lxd: refactor Cleanbuilder into Containerbuild and add Project. snapcraft merged Merged PR #1230 (ce66ca561) replaced Cleanbuilder with a Containerbuild base class and added Project to create and reuse project-named LXD containers.
70%