← Back to issue list

jhbuild plugin: new plugin

View original Github issue

Metadata

Project
snapcraft
Number
#1298
Type
pull request
State
merged
Author
lucyllewy
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1298 (commit f5a51ee09) landed a rewritten, Bubblewrap-free JHBuild plugin by lucyllewy, replacing earlier attempt #924; approved by jhenstridge/kyrofa after review. Plugin later removed in #2371 as base-incompatible.

Resolution: closed resolved

Reason: PR #1298 was merged as commit f5a51ee09 ("jhbuild plugin: new plugin"), landing the simplified plugin without the Bubblewrap dependency that caused #924 to be closed. Reviewer jhenstridge removed his objections on 2017-08-29 after the author dropped the plugin-specific dependency-discovery and jhbuild diff shipping.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1643924 Previous PR: #924 The previous PR was closed due to the attempt relying on a package which isn't available in Xenial. I have taken that PR (props to @attente for the original work, which I have based this PR on) and removed the dependency on Bubblewrap. I then massaged the code to simplify and unify duplicated code. The tests pass on my Xenial LXC container and also pass Travis-CI's suite.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1298 (commit f5a51ee09) landed a rewritten, Bubblewrap-free JHBuild plugin by lucyllewy, replacing earlier attempt #924; approved by jhenstridge/kyrofa after review. Plugin later removed in #2371 as base-incompatible.
stealth/space-bunny-alpha — closed resolved jhbuild plugin PR merged as commit f5a51ee09 after dropping Bubblewrap and jhbuild-patching dependency magic; @jhenstridge lifted objections 2017-08-29. Plugin later removed in #2371.
stealth/space-bunny-alpha — closed resolved Merged PR #1298 (f5a51ee09) added a simplified JHBuild plugin without Bubblewrap, replacing #924. It was later removed as base-incompatible by #2371.
qwen/qwen3.6-35b-a3b — — Merged a new JHBuild plugin for Snapcraft. The contributor removed a Xenial-incompatible dependency, simplified code, and resolved reviewer concerns regarding dependency resolution. Following maintainer approval, the plugin was integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Merged a new jhbuild plugin for Snapcraft. The author removed the unavailable bubblewrap dependency, simplified code, and addressed reviewer feedback on dependency staging. After iterative updates and approvals, the plugin was merged.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#2371 (confidence 92%)

    PR #2371 (commit b46e3f678, LP #1794789) removed the jhbuild plugin as unused and base-incompatible, so the merged work no longer exists in the tree.

  • Related To: snapcraft#924 (confidence 90%)

    Original jhbuild plugin PR by attente; closed because it depended on bubblewrap, unavailable in Xenial. #1298 took it over and dropped that dependency.

  • Related To: snapcraft#1534 (confidence 80%)

    Follow-up fix (commit 67089e050) for UnboundLocalError on chmod_path in the merged jhbuild plugin.

  • Related To: snapcraft#1535 (confidence 78%)

    Follow-up cleanup (commit f93850027) removing the plugin's pkgconf dependency.

  • Related To: snapcraft#2141 (confidence 75%)

    Later fix (commit a017389fd) allowing the jhbuild plugin to run as root.

Related issues

Issue Project State Summary Similarity
#812 New plugin: jhbuild snapcraft closed PR #812 (LXC-based jhbuild plugin by attente, 2016) was closed unmerged in Nov 2016, superseded by #924, which in turn was replaced by the Bubblewrap-free rewrite merged as #1298 (commit f5a51ee09); plugin later removed in #2371.
87%
#924 New plugin: jhbuild snapcraft closed Closed unmerged in Feb 2017 by sergiusens pending a decision on bubblewrap availability in xenial. A Bubblewrap-free rewrite landed later as PR #1298 (commit f5a51ee09).
82%
#2371 plugins: remove jhbuild snapcraft merged PR #2371 (commit b46e3f678) by kyrofa merged, deleting the unused, base-incompatible jhbuild plugin (-503 lines, 8 files), resolving LP bug #1794789. No jhbuild references remain in the repo.
76%