← Back to issue list

jhbuild plugin: new plugin

View original Github issue

Metadata

Project
snapcraft
Number
#1298
Type
pull request
State
merged
Author
lucyllewy
Labels
Created
Updated
Closed

Current evaluation

Merged a new JHBuild plugin for Snapcraft. The contributor removed a Xenial-incompatible dependency, simplified code, and resolved reviewer concerns regarding dependency resolution. Following maintainer approval, the plugin was integrated into the codebase.

Suggested action:

No scores available.

Issue body

LP: #1643924 Previous PR: #924 The previous PR was closed due to the attempt relying on a package which isn't available in Xenial. I have taken that PR (props to @attente for the original work, which I have based this PR on) and removed the dependency on Bubblewrap. I then massaged the code to simplify and unify duplicated code. The tests pass on my Xenial LXC container and also pass Travis-CI's suite.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a new JHBuild plugin for Snapcraft. The contributor removed a Xenial-incompatible dependency, simplified code, and resolved reviewer concerns regarding dependency resolution. Following maintainer approval, the plugin was integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged a new jhbuild plugin for Snapcraft. The author removed the unavailable bubblewrap dependency, simplified code, and addressed reviewer feedback on dependency staging. After iterative updates and approvals, the plugin was merged.
qwen3.6-35b-a3b-mtp-q6 Merged a new jhbuild plugin for Snapcraft. It removed the unavailable bubblewrap dependency, simplified dependency resolution to align with Snapcraft's built-in behavior, and eliminated custom patches. Approved after addressing reviewer concerns.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#812 New plugin: jhbuild snapcraft closed Superseded by pull request #924, which implements the jhbuild plugin without requiring LXC. The original was closed with unresolved review comments after the author noted the replacement.
77%
#924 New plugin: jhbuild snapcraft closed The jhbuild plugin was closed and abandoned pending clarification on bubblewrap compatibility with Ubuntu Xenial. Maintainers cited versioning conflicts and requested a decision before resubmission.
72%
#2371 plugins: remove jhbuild snapcraft merged Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks.
72%
#1535 jhbuild plugin: remove dependency on pkgconf snapcraft merged Merged changes remove the pkgconf dependency from the jhbuild plugin to resolve a pkg-config conflict. Approved by three reviewers, passed CI checks, and deleted one line.
71%
#340 plugins: add maven plugin craft-parts merged Successfully merged the Snapcraft V1 Maven plugin port. It integrates the plugin using shared Java infrastructure, passed approval, was rebased on main after the base Java plugin landed, and was finalized.
71%