catkin plugin: rosinstall-files is a pull property
Metadata
Current evaluation
Merged PR #1473 corrected the catkin plugin to treat rosinstall-files as a pull property, committed as 09fcddf13.
Resolution: closed resolved
Reason: PR #1473 was approved and merged, with commit 09fcddf13 moving rosinstall-files from push to pull properties in the plugin and tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Missed this when adding the `rosinstall-files` feature, sorry about that.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1473 corrected the catkin plugin to treat rosinstall-files as a pull property, committed as 09fcddf13. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#1473, correcting the catkin plugin so rosinstall-files is configured as a pull property rather than a push property. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a maintainer correction updating the catkin plugin. The rosinstall-files property was incorrectly configured as a push property and has been changed to a pull property. Approved by two reviewers with a three-line fix across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a correction to the catkin plugin, ensuring rosinstall-files is correctly defined as a pull property. This resolves an oversight from the feature's initial implementation. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1314
(confidence 95%)
Introduced catkin rosinstall-files support and contained the property misclassification corrected by #1473.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1533735 Catkin plugin: Support rosinstall files | snapcraft (launchpad) | closed | Catkin rosinstall support was merged in PR #1314 (commit 97a416d0a); rosinstall-files was later corrected to a pull property in #1473. | |
| #1314 catkin plugin: add support for rosinstall files | snapcraft | merged | Merged PR #1314 as commit 97a416d0a, adding ordered multi-file rosinstall support to the Catkin plugin and resolving Launchpad #1533735. | |
| #1934 catkin plugin: support recursive rosinstall files | snapcraft | merged | Merged PR #1934 (commit 6bb63bb25) adds an opt-in `recursive-rosinstall` option to the Catkin plugin, merging nested rosinstall files from fetched repos. Fixes issue #1714; tested on the stable/pr-1934-recursive-rosinstall channel. | |
| #1714 catkin plugin: recursively merge rosinstall files | snapcraft | closed | Added opt-in recursive rosinstall support to the Catkin plugin, discovering and merging nested rosinstall files in canonical/snapcraft#1934. | |
| #1715 catkin plugin: detect and gracefully handle rosinstall clashes | snapcraft | closed | Abandoned as unnecessary: recursive rosinstall fetching was supported via #1934 (6bb63bb25), and @kyrofa said clash detection offered no gain. | |
| #1392 catkin plugin: extract rosdep into new package | snapcraft | merged | Merged in canonical/snapcraft#1392 (99218f59d), extracting rosdep from Catkin into internal.pullers and resolving #1464. | |
| #1581 catkin plugin: support rosdep pip dependencies | snapcraft | merged | Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036. |