catkin plugin: rosinstall-files is a pull property
Metadata
Current evaluation
Merged a maintainer correction updating the catkin plugin. The rosinstall-files property was incorrectly configured as a push property and has been changed to a pull property. Approved by two reviewers with a three-line fix across two files.
Suggested action: —
No scores available.
Issue body
Missed this when adding the `rosinstall-files` feature, sorry about that.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a maintainer correction updating the catkin plugin. The rosinstall-files property was incorrectly configured as a push property and has been changed to a pull property. Approved by two reviewers with a three-line fix across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a correction to the catkin plugin, ensuring rosinstall-files is correctly defined as a pull property. This resolves an oversight from the feature's initial implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to correctly define rosinstall-files as a pull property in the catkin plugin, addressing a missed implementation detail from the original feature addition. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1314 catkin plugin: add support for rosinstall files | snapcraft | merged | Merged. Introduces a rosinstall-files property to the Catkin plugin, allowing Snapcraft to manage ROS workspace dependencies. Approved by a reviewer and merged after resolving CI test delays. Resolves Launchpad bug 1533735. | |
| #1934 catkin plugin: support recursive rosinstall files | snapcraft | merged | Merged. Introduces a recursive-rosinstall boolean option to the Catkin plugin, enabling automatic resolution of nested rosinstall files unsupported by wstool. Defaults to false. Resolves #1714 following successful review and CI checks. | |
| #1714 catkin plugin: recursively merge rosinstall files | snapcraft | closed | The request to recursively merge rosinstall files in the catkin plugin was closed without implementation or discussion. The feature was not added and the issue appears abandoned. | |
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled. | |
| #851 catkin plugin: nicely handle an invalid rosdistro. | snapcraft | merged | Merged changes add rosdistro validation to the catkin plugin, replacing cryptic key errors with clear messages. Approved by reviewers and passed CI. Minor refactoring feedback was noted but did not block the merge. | |
| #1533735 Catkin plugin: Support rosinstall files | snapcraft (launchpad) | closed | Closed without implementation. The request to add rosinstall file support to the Catkin plugin was abandoned due to zero comments and prolonged inactivity. | |
| #1715 catkin plugin: detect and gracefully handle rosinstall clashes | snapcraft | closed | Rejected. Maintainer cancelled the feature because vendors do not require recursive rosinstall parsing or clash detection, and recursive fetching is already supported. Low demand and implementation complexity led to abandonment. | |
| #468 catkin plugin: use ProjectOptions for repo setup | snapcraft | merged | Merged changes updating the catkin plugin to use ProjectOptions for repository setup. The pull request modifies three files (+18/-8 lines), successfully tested with a ROS example snap, and received reviewer approval. | |
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. | |
| #1472 catkin plugin: include-roscore is a boolean | snapcraft | merged | Merged a fix replacing the string 'true' with boolean True in the catkin plugin. Corrects an incorrect type and improves code examples without functional impact. Approved by two reviewers. |