← Back to issue list

catkin plugin: add support for rosinstall files

View original Github issue

Metadata

Project
snapcraft
Number
#1314
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged. Introduces a rosinstall-files property to the Catkin plugin, allowing Snapcraft to manage ROS workspace dependencies. Approved by a reviewer and merged after resolving CI test delays. Resolves Launchpad bug 1533735.

Suggested action:

No scores available.

Issue body

ROS projects are often made up of many sub-projects. Some created by the community, some created by OSRF, others created by the robotics vendor themselves. Projects use rosinstall files for keeping track of all these dependencies and pulling them into the same workspace. However, currently Snapcraft doesn't support rosinstall files. This PR resolves LP: [#1533735](https://bugs.launchpad.net/snapcraft/+bug/1533735) by introducing support for rosinstall files in the Catkin plugin. It does this by adding a new property to the plugin: `rosinstall-files`. Multiple rosinstall files can be added, and they will be merged into the workspace in the order given.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Introduces a rosinstall-files property to the Catkin plugin, allowing Snapcraft to manage ROS workspace dependencies. Approved by a reviewer and merged after resolving CI test delays. Resolves Launchpad bug 1533735.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces a rosinstall-files property to the Catkin plugin, enabling workspace merging of multiple rosinstall files. Resolves Launchpad bug #1533735 following code review approval and resolution of temporary autopkgtest delays.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Adds a rosinstall-files property to the Catkin plugin to merge and process ROS workspace dependencies. The change passed review and resolved ARM autopkgtest failures before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1473 catkin plugin: rosinstall-files is a pull property snapcraft merged Merged a maintainer correction updating the catkin plugin. The rosinstall-files property was incorrectly configured as a push property and has been changed to a pull property. Approved by two reviewers with a three-line fix across two files.
82%
#1934 catkin plugin: support recursive rosinstall files snapcraft merged Merged. Introduces a recursive-rosinstall boolean option to the Catkin plugin, enabling automatic resolution of nested rosinstall files unsupported by wstool. Defaults to false. Resolves #1714 following successful review and CI checks.
79%
#1533735 Catkin plugin: Support rosinstall files snapcraft (launchpad) closed Closed without implementation. The request to add rosinstall file support to the Catkin plugin was abandoned due to zero comments and prolonged inactivity.
79%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled.
78%
#2525 catkin plugin: check stage-snaps for ROS dependencies snapcraft merged Merged to master. Updates the catkin plugin to check stage-snaps for ROS dependencies, preventing redundant fetching by treating them like underlays. Resolves Launchpad bug #1823788. Approved, passed CI, and merged.
77%
#1581 catkin plugin: support rosdep pip dependencies snapcraft merged Merged implementation adding pip-based dependency support to the Catkin plugin's rosdep resolver, resolving Launchpad bug #1683036. Approved by one reviewer, passed CI, and modified 12 files.
77%
#1367 catkin plugin: add support for ROS Lunar snapcraft merged Merged the catkin plugin update to support ROS Lunar alongside Indigo, Jade, and Kinetic. CI initially failed due to a Launchpad bug, resolved by adding lsb-release to build-packages. Approved and merged after passing integration tests.
75%
#1392 catkin plugin: extract rosdep into new package snapcraft merged Merged. Extracts rosdep from the catkin plugin into snapcraft.plugins.internal.pullers to enable future Ament and ROS 2 support. Updates plugin loading to ignore internal packages, resolving issue #1464.
75%
#850 catkin plugin: add `rosdistro` to help documentation. snapcraft merged Merged documentation update for the catkin plugin adding the rosdistro parameter to snapcraft help catkin output, resolving Launchpad bug 1629955. Approved by one reviewer with three lines added.
75%
#1714 catkin plugin: recursively merge rosinstall files snapcraft closed The request to recursively merge rosinstall files in the catkin plugin was closed without implementation or discussion. The feature was not added and the issue appears abandoned.
74%