← Back to issue list

catkin plugin: add support for rosinstall files

View original Github issue

Metadata

Project
snapcraft
Number
#1314
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1314 as commit 97a416d0a, adding ordered multi-file rosinstall support to the Catkin plugin and resolving Launchpad #1533735.

Resolution: closed resolved

Reason: PR #1314 was merged into master as commit 97a416d0a, introducing the rosinstall-files property so multiple ROS workspace files are merged in declared order. Follow-up PR #1473 later corrected the property classification in commit 09fcddf13.

Evaluated by: mr-cal-bot

No scores available.

Issue body

ROS projects are often made up of many sub-projects. Some created by the community, some created by OSRF, others created by the robotics vendor themselves. Projects use rosinstall files for keeping track of all these dependencies and pulling them into the same workspace. However, currently Snapcraft doesn't support rosinstall files. This PR resolves LP: [#1533735](https://bugs.launchpad.net/snapcraft/+bug/1533735) by introducing support for rosinstall files in the Catkin plugin. It does this by adding a new property to the plugin: `rosinstall-files`. Multiple rosinstall files can be added, and they will be merged into the workspace in the order given.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1314 as commit 97a416d0a, adding ordered multi-file rosinstall support to the Catkin plugin and resolving Launchpad #1533735.
stealth/space-bunny-alpha — closed resolved Merged #1314, adding Catkin rosinstall-files support so multiple ROS workspace dependency files are merged in order; resolves Launchpad bug #1533735.
qwen/qwen3.6-35b-a3b — — Merged. Introduces a rosinstall-files property to the Catkin plugin, allowing Snapcraft to manage ROS workspace dependencies. Approved by a reviewer and merged after resolving CI test delays. Resolves Launchpad bug 1533735.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces a rosinstall-files property to the Catkin plugin, enabling workspace merging of multiple rosinstall files. Resolves Launchpad bug #1533735 following code review approval and resolution of temporary autopkgtest delays.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1473 (confidence 98%)

    Follow-up PR #1473 corrected rosinstall-files to be a pull property; merged as 09fcddf13.

Related issues

Issue Project State Summary Similarity
#1533735 Catkin plugin: Support rosinstall files snapcraft (launchpad) closed Catkin rosinstall support was merged in PR #1314 (commit 97a416d0a); rosinstall-files was later corrected to a pull property in #1473.
90%
#1934 catkin plugin: support recursive rosinstall files snapcraft merged Merged PR #1934 (commit 6bb63bb25) adds an opt-in `recursive-rosinstall` option to the Catkin plugin, merging nested rosinstall files from fetched repos. Fixes issue #1714; tested on the stable/pr-1934-recursive-rosinstall channel.
86%
#1473 catkin plugin: rosinstall-files is a pull property snapcraft merged Merged PR #1473 corrected the catkin plugin to treat rosinstall-files as a pull property, committed as 09fcddf13.
84%
#1714 catkin plugin: recursively merge rosinstall files snapcraft closed Added opt-in recursive rosinstall support to the Catkin plugin, discovering and merging nested rosinstall files in canonical/snapcraft#1934.
84%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged #152 as fc5142126, adding ROS package installation, roslaunch/rosrun support, updated examples, and doubled Catkin test coverage.
81%
#1367 catkin plugin: add support for ROS Lunar snapcraft merged Merged PR #1367 (commit ba722e847), adding ROS Lunar support and the lsb-release build workaround for Launchpad bug #1677002.
80%
#1581 catkin plugin: support rosdep pip dependencies snapcraft merged Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.
76%
#1715 catkin plugin: detect and gracefully handle rosinstall clashes snapcraft closed Abandoned as unnecessary: recursive rosinstall fetching was supported via #1934 (6bb63bb25), and @kyrofa said clash detection offered no gain.
74%
#842 Catkin plugin: Support ROS Kinetic. snapcraft merged Merged as commit 5d447aedc, adding ROS Kinetic support to the catkin plugin by refactoring repository source handling into an overridable function and adding a ROS-release-to-Ubuntu-release map (fixes LP #1629003).
74%
#850 catkin plugin: add `rosdistro` to help documentation. snapcraft merged Merged PR #850 (commit c3817b42d) added the `rosdistro` parameter to `snapcraft help catkin` output, closing Launchpad bug #1629955. Docs-only change, 3 lines added.
71%