← Back to issue list

plugins: extract python finder functions

View original Github issue

Metadata

Project
snapcraft
Number
#1540
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged after approvals and CI. Extracts Python finder functions into a shared module as the first step in a series to refactor the python plugin and address bug LP: #1683036. Introduces no functional changes.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This PR is the first in a series that extracts pip from the python plugin, thus making progress on LP: [#1683036](https://bugs.launchpad.net/snapcraft/+bug/1683036). It makes no changes to the Python plugin just yet, just copies functionality out into a more accessible place.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approvals and CI. Extracts Python finder functions into a shared module as the first step in a series to refactor the python plugin and address bug LP: #1683036. Introduces no functional changes.
qwen3.6-35b-a3b-mtp-q6 Merged after review. Extracts Python finder functions from the python plugin into a shared module as the first refactoring step to decouple pip. Squashed, passed CI, and merged following minor test and documentation updates.
qwen3.6-35b-a3b-mtp-q6 Merged after review and squash. Extracts Python finder functions from the Python plugin into a shared module for future decoupling. First step in a multi-PR refactoring series. All checks passed and PR #1444 referenced.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1549 plugins: extract pip from python plugin snapcraft merged Merged a refactor extracting the pip wrapper from the Python plugin. Introduces a public API to improve reusability and testability. Approved by two reviewers with passing CI checks, advancing a larger plugin extraction effort.
72%
#1547 plugins: extract sitecustomize logic from python snapcraft merged Merged a refactoring change extracting sitecustomize.py logic from the Python plugin into a shared module. Approved and passing CI, this prepares the codebase for the subsequent pip extraction without altering current functionality.
71%