plugins: extract python finder functions
Metadata
Current evaluation
Merged as commit 822774f1f, extracting Python finder helpers into a shared module without changing plugin behavior and advancing the pip/catkin extraction effort.
Resolution: closed resolved
Reason: PR snapcraft#1540 was approved and merged into the main project as commit 822774f1f.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
This PR is the first in a series that extracts pip from the python plugin, thus making progress on LP: [#1683036](https://bugs.launchpad.net/snapcraft/+bug/1683036). It makes no changes to the Python plugin just yet, just copies functionality out into a more accessible place.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 822774f1f, extracting Python finder helpers into a shared module without changing plugin behavior and advancing the pip/catkin extraction effort. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#1540 as commit 822774f1f, extracting Python finder helpers into a shared module without changing plugin behavior, advancing pip/catkin support. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approvals and CI. Extracts Python finder functions into a shared module as the first step in a series to refactor the python plugin and address bug LP: #1683036. Introduces no functional changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after review. Extracts Python finder functions from the python plugin into a shared module as the first refactoring step to decouple pip. Squashed, passed CI, and merged following minor test and documentation updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1444
(confidence 100%)
The maintainer explicitly added this PR to the commit referencing the catkin pip-support issue.
-
Related To:
snapcraft#1581
(confidence 90%)
The later pip-based catkin support PR built on the finder extraction groundwork from #1540.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1549 plugins: extract pip from python plugin | snapcraft | merged | Merged #1549 in commit 871d4eee4, extracting the Python plugin's Pip wrapper into a reusable API with expanded tests; Python plugin behavior remained unchanged. |