tests: move test files out of the snapcraft dir
Metadata
Current evaluation
Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Moving test files out of the snapcraft directory was abandoned. Local tests passed, but a merge conflict arose. The author closed the request, citing the conflict as too complex, and planned to retry the move later. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned due to a merge conflict. The author closed the pull request without merging, stating the conflict was too difficult and intending to redo the test file relocation separately. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| #4662 fix(test): do not create 2 snapcraft.yaml and confuse location | snapcraft | merged | Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged after two approvals. The PR updates integration tests to run against the installed snapcraft snap, aligning with user environments. Despite a reported Go runtime address space conflict in CI, the changes were accepted and merged. | |
| #1394 tests: document the test suites in the snapcraft repo | snapcraft | merged | Test suite documentation added to snapcraft. Approved by two reviewers, the merge updated two files with 160 additions and 33 deletions to clarify test execution. Reviewer feedback was incorporated prior to merging. | |
| #1652 tests: fork skip into snaps_tests | snapcraft | merged | Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files. | |
| #1013 fix(LifecycleService): pull local test files | craft-application | merged | Merged following successful CI checks and approvals. Resolves #942 by fixing LifecycleService to pull local test files, updates the cryptography dependency, and adds verification tests. Unblocks snapcraft issue #5831. |