tests: move test files out of the snapcraft dir
Metadata
Current evaluation
Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package.
Resolution: closed superseded
Reason: PR #1877 was superseded after repeated merge conflicts. snapcraft#1948 completed the same test move and merged as commit 55ad11ccc.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| stealth/space-bunny-alpha | — | closed resolved | Approved test reorganization was merged in snapcore/snapcraft#1948 as commit 55ad11ccc, moving test files out of the snapcraft directory. | |
| qwen/qwen3.6-35b-a3b | — | — | Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Moving test files out of the snapcraft directory was abandoned. Local tests passed, but a merge conflict arose. The author closed the request, citing the conflict as too complex, and planned to retry the move later. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#1948
(confidence 100%)
Replacement PR merged the same test reorganization in commit 55ad11ccc.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged PR #1625 updated integration tests to run the installed Snapcraft snap, better matching the user environment. Resolution: commit eebb070e6. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| #1394 tests: document the test suites in the snapcraft repo | snapcraft | merged | Merged PR #1394 in commit ddf06b948, documenting Snapcraft's test suites across two files for contributors. | |
| #1651903 Plugin tests need to be reorganized | snapcraft (launchpad) | closed | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| #1838 tests: fix broken rust test snap | snapcraft | merged | Merged in snapcraft#1838 as 0fe7def33, removing an unnecessary unversioned log dependency that broke the rust-with-revisions test snap. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982. |