← Back to issue list

tests: fix broken rust test snap

View original Github issue

Metadata

Project
snapcraft
Number
#1838
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#1838 as 0fe7def33, removing an unnecessary unversioned log dependency that broke the rust-with-revisions test snap.

Resolution: closed resolved

Reason: PR #1838 was approved and merged as commit 0fe7def33, fixing the Rust test snap by removing the incompatible dependency.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The test snap rust-with-revisons had an unnecessary dependency on the `log` crate which was unversioned. The latest version of `log` breaks with the rust revision this snap is fixed to. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#1838 as 0fe7def33, removing an unnecessary unversioned log dependency that broke the rust-with-revisions test snap.
stealth/space-bunny-alpha — closed resolved Merged in #1838 (commit 0fe7def33): removed the unversioned log dependency from the rust-with-revisons test snap after it broke against the snap's pinned Rust revision.
qwen/qwen3.6-35b-a3b — — Merged a fix for a broken Rust test snap by removing an unversioned log crate dependency that caused build failures with the target Rust revision. The update ensures test compatibility and passes all checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for a broken Rust test snap caused by an unversioned log crate dependency conflicting with a pinned Rust revision. The dependency was updated to resolve the test failure.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
76%
#1877 tests: move test files out of the snapcraft dir snapcraft closed Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package.
72%
#2169 Rust plugin improvements snapcraft closed Closed unmerged and superseded by snapcraft#2170, merged as commit 4f80a1051 to fix Cargo builds and add Rust plugin tests.
72%
#1655203 rust test with revision is skipped in armhf snapcraft (launchpad) closed Fixed by PR snapcraft#1040, which changed the Rust integration-test revision to one supporting armhf.
72%
#2096 tests: don't use os_release and repo from snapcraft snapcraft merged Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982.
72%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666.
71%
#4755 tests: fix devel base snap test snapcraft merged Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable.
71%
#2158 rust plugin: fix cargo builds and run tests snapcraft closed PR closed as superseded: the rust-plugin-improvements branch was deleted and the work was reworked and merged as snapcore/snapcraft#2170 (commit 4f80a1051) after cargo test broke cross-compilation.
70%