← Back to issue list

Fix Store integration tests with updated snap name registration error messages

View original Github issue

Metadata

Project
snapcraft
Number
#1963
Type
pull request
State
closed
Author
maxiberta
Labels
—
Created
Updated
Closed

Current evaluation

PR #1963 (maxiberta) updated Store integration tests for new snap-name validation errors but was closed unmerged by the author on 2018-02-28 in favour of #1964, which merged as commit 44ecb321a.

Resolution: closed superseded

Reason: The author closed #1963 with the comment 'Closing in favour of snapcore/snapcraft#1964'. That replacement PR was merged and landed as commit 44ecb321a ('tests: adapt store tests with new snap name registration error messages (#1964)'), so #1963 itself was never merged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Recent improvements in snap name validation in the Store have updated the content of error messages. This branch updates a couple of integration tests accordingly. Bug: https://bugs.launchpad.net/snapstore/+bug/1751447 Store changes: https://code.launchpad.net/~chipaca/software-center-agent/fix-name-check/+merge/339453 Related snapcraft brach: https://github.com/snapcore/snapcraft/pull/1957

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #1963 (maxiberta) updated Store integration tests for new snap-name validation errors but was closed unmerged by the author on 2018-02-28 in favour of #1964, which merged as commit 44ecb321a.
stealth/space-bunny-alpha — closed superseded PR #1963 updated Store integration tests for new snap-name registration error messages, but was closed by the author in favour of #1964, which was merged as commit 44ecb321a carrying the same test changes.
stealth/space-bunny-alpha — closed superseded Closed in favor of #1964, which merged the Store integration-test updates for new snap-name registration errors in commit 44ecb321a.
qwen/qwen3.6-35b-a3b — — Closed in favor of PR #1964. The branch updated integration tests for new snap name validation error messages but was superseded by a subsequent pull request.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #1964. Integration tests were updated to match new snap name validation error messages from the Store. Closed without merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1964 (confidence 99%)

    Explicit closing comment points to #1964 ('take 2'), which merged as commit 44ecb321a with the same Store integration-test error-message updates (bug 1751447).

  • Duplicate Of: snapcraft#1957 (confidence 70%)

    PR #1957 is cited in the body as the related/earlier snapcraft branch for the same Launchpad bug 1751447 fix.

Related issues

Issue Project State Summary Similarity
#1964 Fix Store integration tests with updated snap name registration error messages (take 2) snapcraft merged Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963.
86%
#1247 Fixing Store integration tests. snapcraft merged Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit.
81%
#1797 tests: update the snap name already registered for store tests snapcraft merged Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a.
75%
#631 Fix the store integration tests snapcraft merged Merged PR #631 (commit 351d4aaac) fixed store integration tests by pausing after rapid snap registrations so later tests did not inherit the rate-limit error.
74%
#2086 tests: update metadata store integration test, no previous push required snapcraft merged Merged PR #2086 in commit 3882853b7, updating the metadata-store integration test for approved snap names whose metadata can be changed before any revision push.
71%