← Back to issue list

Fix the store integration tests

View original Github issue

Metadata

Project
snapcraft
Number
#631
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #631 (commit 351d4aaac) fixed store integration tests by pausing after rapid snap registrations so later tests did not inherit the rate-limit error.

Resolution: closed not a bug

Reason: The change was a test-timing fix rather than a production-code defect. PR #631 added a short delay after the too-many-registrations test to prevent subsequent registrations from triggering the same store error.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The tests were failing because we added a new one that attempts to register two snaps too fast, in order to check the error the store sends for too many attempts. After the second registration, we need to wait a little so the following tests can register without getting the same error. LP: #1599268

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug Merged PR #631 (commit 351d4aaac) fixed store integration tests by pausing after rapid snap registrations so later tests did not inherit the rate-limit error.
stealth/space-bunny-alpha — closed resolved Merged PR #631 to fix store integration tests by delaying later snap registrations after the rapid-registration error test, avoiding rate-limit failures.
qwen/qwen3.6-35b-a3b — — Merged a fix for failing store integration tests caused by rate-limiting during rapid snap registrations. Added a wait delay after the second registration to prevent subsequent tests from hitting the same error.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for failing store integration tests caused by rapid consecutive snap registrations. Added a delay after the second registration to prevent subsequent tests from triggering rate-limit errors.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#630 (confidence 90%)

    Related rate-limit handling/test work identified with commit 1a5ff1f98 preceded this stabilization fix.

Related issues

Issue Project State Summary Similarity
#1247 Fixing Store integration tests. snapcraft merged Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit.
77%
#5370 test: fix store tests snapcraft closed Store-test fixes were superseded by merged #5954, updating credentials and configuration after secret re-provisioning in commit 0be1e384d.
74%
#1963 Fix Store integration tests with updated snap name registration error messages snapcraft closed PR #1963 (maxiberta) updated Store integration tests for new snap-name validation errors but was closed unmerged by the author on 2018-02-28 in favour of #1964, which merged as commit 44ecb321a.
74%
#1460 fix(tests): make store spread tests less flaky charmcraft merged Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429.
73%
#5954 tests: fix store tests snapcraft merged PR #5954 merged as commit 0be1e384d: store spread tests switched to new staging credentials/key test-staging-key-2 and to wheel-based automated tests (as in #5885).
73%
#1223 tests: fix resource spread test charmcraft merged Merged #1223 (commit 35993996), fixing the flaky store-resources spread test and advancing #1193; related store fixes landed in #1226 and #1234.
71%
#1984 tests: update store tests user snapcraft merged Merged PR #1984 (3c313dab1), updating the Store test account, removing two obsolete tests, and revising related test data, documentation, and warnings.
71%
#1964 Fix Store integration tests with updated snap name registration error messages (take 2) snapcraft merged Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963.
71%
#687 Enable integration tests to run in the production store snapcraft merged Merged #687 via commit e3f0bbea0, enabling integration tests to use the production store and consolidating TestStore configuration.
71%
#2903 tests: fix status test for staging store snapcraft merged Merged PR #2903 as commit 0f0492482, correcting the status test for the staging store.
71%