← Back to issue list

tests: add SNAPCRAFT_KEEP_DATA to debug

View original Github issue

Metadata

Project
snapcraft
Number
#1996
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged test updates adding the SNAPCRAFT_KEEP_DATA environment variable for debugging. Approved by two reviewers, the change modifies two files with a net addition of 14 lines. Submitted as a farewell gift to @sergiusens.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Farewell gift for @sergiusens .

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged test updates adding the SNAPCRAFT_KEEP_DATA environment variable for debugging. Approved by two reviewers, the change modifies two files with a net addition of 14 lines. Submitted as a farewell gift to @sergiusens.
qwen3.6-35b-a3b-mtp-q6 — — Merged adding the SNAPCRAFT_KEEP_DATA environment variable to tests for debugging. Integrated directly without comments or revisions.
qwen3.6-35b-a3b-mtp-q6 — — Merged adding SNAPCRAFT_KEEP_DATA to tests for debugging. The change passed static and unit checks and was accepted without comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2130 tests: remove obsolete env var snapcraft merged Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file.
81%
#2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere snapcraft merged Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact.
72%
#2696 shell_utils: Add SNAPCRAFT_DEBUG_SCRIPTS env variable snapcraft closed Superseded by another PR that implemented the SNAPCRAFT_DEBUG_SCRIPTS feature. Maintainers noted the merged code requires adjustments based on discussions in this closed request, which remains abandoned with unresolved review comments.
72%
#4041 utils: log envvar SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT when invalid snapcraft merged Merged into main. Adds logging for the SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable when invalid. Approved by reviewer, passed CI, and contains no functional changes.
71%
#2943 spread: capture developer debug information snapcraft merged Merged changes setting SNAPCRAFT_ENABLE_DEVELOPER_DEBUG=yes in the spread environment to capture debug logs on failure. Approved by one reviewer, passed CI, and updated four files with twelve added lines.
71%
#2793 tests: enable SNAPCRAFT_BUILD_INFO for spread snapcraft merged Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files.
71%
#4699 fix(log): map SNAPCRAFT_VERBOSITY_LEVEL to CRAFT snapcraft merged Merged a fix mapping SNAPCRAFT_VERBOSITY_LEVEL to CRAFT logging. Approved by three reviewers with passing test coverage. The change modifies five files, adding 30 lines and removing 4.
70%
#3748 parts: define variables and expand them in snapcraft.yaml snapcraft merged Merged after approval and passing CI. Adds global and step-specific SNAPCRAFT_* variables for snapcraft.yaml and lifecycle execution, extending CRAFT_* support. A reviewer requested a spread test rerun for 22.04.
70%
#5396 Export variables to testing environment snapcraft open Enhancement to export SNAPCRAFT_PROJECT_DIR, SNAPCRAFT_PROJECT_VERSION, and CRAFT_ARCH_BUILD_FOR into the testing environment so test projects can reference the generated snap path. Triaged by maintainer; no implementation or PR found in repo.
70%