← Back to issue list

tests: enable SNAPCRAFT_BUILD_INFO for spread

View original Github issue

Metadata

Project
snapcraft
Number
#2793
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 12370aae1, enabling SNAPCRAFT_BUILD_INFO across Spread tests to exercise manifest generation and updating nil-basic for the resulting manifest.

Resolution: closed resolved

Reason: PR #2793 was merged as commit 12370aae1. It enabled SNAPCRAFT_BUILD_INFO for Spread tests and adjusted the nil-basic test to account for manifest generation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Provide additional test coverage of manifest-related changes. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 12370aae1, enabling SNAPCRAFT_BUILD_INFO across Spread tests to exercise manifest generation and updating nil-basic for the resulting manifest.
stealth/space-bunny-alpha — closed resolved Merged as commit 12370aae1: enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest generation, with a nil-basic spread-test fix.
qwen/qwen3.6-35b-a3b — — Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enables SNAPCRAFT_BUILD_INFO for spread tests to cover manifest-related changes. Includes a fix for the nil-basic spread test to handle manifest generation. Approved by sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap.
77%
#5845 test(spread): test building base and snapd snaps snapcraft merged Merged as fb8c81e8f, adding manual Spread coverage that builds current base snaps and the snapd snap against mainline Snapcraft.
76%
#2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere snapcraft merged PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379)
75%
#386 tests: update testing to use craft-test fetch-service merged Merged #386 as commit 323b0e1, replacing direct Spread calls with snapcraft test and updating the test base to core24.
75%
#3312 spread tests: introduce electron-builder test snapcraft merged Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test with snapcraft.yaml and meta/snap.yaml comparisons.
74%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files.
73%
#16 tests: add spread support rockcraft merged Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a).
72%
#1996 tests: add SNAPCRAFT_KEEP_DATA to debug snapcraft merged Merged PR #1996 added SNAPCRAFT_KEEP_DATA_PATH support to retain integration-test data for debugging; landed as commit 0024c35ff.
72%
#3212 tests: expand spread coverage for stage-snaps snapcraft closed Spread-test PR was closed unmerged in favor of snapcraft#3211, merged as 0870f1738 to fix stage-snaps handling for v2 plugins.
71%
#1007 fix(craft-test): enable spread tests with 26.04 backends craft-application closed Merged via canonical/snapcraft#6018, adding a temporary ubuntu-daily fallback so Spread tests could use 26.04 backends before ubuntu:26.04 images existed.
70%