← Back to issue list

tests: enable SNAPCRAFT_BUILD_INFO for spread

View original Github issue

Metadata

Project
snapcraft
Number
#2793
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files.

Suggested action: —

No scores available.

Issue body

Provide additional test coverage of manifest-related changes. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enables SNAPCRAFT_BUILD_INFO for spread tests to cover manifest-related changes. Includes a fix for the nil-basic spread test to handle manifest generation. Approved by sergiusens.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable SNAPCRAFT_BUILD_INFO for spread tests, adding coverage for manifest-related changes. Included a fix for the nil-basic spread test to accommodate the new manifest output.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%.
80%
#16 tests: add spread support rockcraft merged Merged after approval and passing CI, adding spread support to tests per CRAFT-865.
79%
#5845 test(spread): test building base and snapd snaps snapcraft merged Merged spread tests for building base and snapd snaps. Despite initial CI failures linked to snapcraft issue #5843, the changes were approved and integrated to maintain build compatibility with mainline snapcraft.
79%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
78%
#5389 test(spread): trace logs in spread tests snapcraft merged Merged after approval. Added trace logging to spread tests. Despite CI failures from extra snapcraft output, the change was approved and merged following a related feature branch integration to prevent conflicts.
78%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127.
78%
#2943 spread: capture developer debug information snapcraft merged Merged changes setting SNAPCRAFT_ENABLE_DEVELOPER_DEBUG=yes in the spread environment to capture debug logs on failure. Approved by one reviewer, passed CI, and updated four files with twelve added lines.
78%
#2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere snapcraft merged Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact.
77%
#102 test: update craftctl test snapcraft-rocks merged Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines.
77%
#3806 spread: add build packages to package repository tests snapcraft merged Merged pull request adding spread tests to verify build packages install via snapcraft.yaml package repositories in destructive and build instance modes. Approved and merged with no coverage impact.
76%