tests: use SNAPCRAFT_PACKAGE_TYPE everywhere
Metadata
Current evaluation
Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact.
Suggested action: —
No scores available.
Issue body
Retire the use of SNAPCRAFT_FROM_ environment variables to smooth
the transition of these legacy tests into spread.
Also remove the unused container tests.
LP: #1794379
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Replaced legacy SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across the test suite and removed unused container tests. Merged to master with no change in code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged PR #2295 replaces SNAPCRAFT_FROM_ variables with SNAPCRAFT_PACKAGE_TYPE across tests and removes unused container tests. This streamlines the spread testing transition with unchanged code coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2793 tests: enable SNAPCRAFT_BUILD_INFO for spread | snapcraft | merged | Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files. | |
| #1794379 SNAPCRAFT_PACKAGE_TYPE for tests | snapcraft (launchpad) | closed | Proposed migration from SNAPCRAFT_FROM_ to SNAPCRAFT_PACKAGE_TYPE for integration tests was closed without implementation. The request appears abandoned or superseded by updated test infrastructure, with no comments or follow-up actions recorded. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #2130 tests: remove obsolete env var | snapcraft | merged | Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR removing os_release and repo imports from the snapcraft module in integration tests, replacing them with dedicated modules. Fixes #1982. Approved by two reviewers and merged despite a suggestion to extract shared functionality. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). | |
| #97 utils: fix snap environment detection and add tests (CRAFT-376) | craft-parts | merged | Merged. Fixed snap environment detection and added tests for is_snap() and is_inside_container(). Updated is_snap() to require an application name, refactored package manager | |
| #1652 tests: fork skip into snaps_tests | snapcraft | merged | Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files. | |
| #1996 tests: add SNAPCRAFT_KEEP_DATA to debug | snapcraft | merged | Merged test updates adding the SNAPCRAFT_KEEP_DATA environment variable for debugging. Approved by two reviewers, the change modifies two files with a net addition of 14 lines. Submitted as a farewell gift to @sergiusens. | |
| #4638 fix(application): use SNAPCRAFT_MANAGED_MODE everywhere | snapcraft | merged | Merged. Replaces CRAFT_MANAGED_MODE with SNAPCRAFT_MANAGED_MODE to fix log loss in nested LXD instances. Approved by two reviewers and passed CI. Does not address unrelated spread test failures. |