← Back to issue list

tests: use SNAPCRAFT_PACKAGE_TYPE everywhere

View original Github issue

Metadata

Project
snapcraft
Number
#2295
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379)

Resolution: closed resolved

Reason: The PR itself was merged into master as commit ffbad69ea ("tests: use SNAPCRAFT_PACKAGE_TYPE everywhere (#2295)", 11 files, +26/-39), retiring SNAPCRAFT_FROM_* test variables and deleting unused container tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Retire the use of SNAPCRAFT_FROM_ environment variables to smooth the transition of these legacy tests into spread. Also remove the unused container tests. LP: #1794379 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379)
stealth/space-bunny-alpha — closed resolved PR #2295 merged (commit ffbad69ea): tests now use SNAPCRAFT_PACKAGE_TYPE everywhere, retiring legacy SNAPCRAFT_FROM_* env vars and dropping unused container tests, easing migration of legacy tests to spread (LP #1794379).
stealth/space-bunny-alpha — closed resolved Merged PR #2295 (commit ffbad69ea): integration tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* variables, and unused container tests were removed, paving the way for moving tests to spread. Closes LP bug #1794379.
stealth/space-bunny-alpha — closed resolved Merged #2295, replacing legacy SNAPCRAFT_FROM_ test variables with SNAPCRAFT_PACKAGE_TYPE and removing unused container tests.
qwen/qwen3.6-35b-a3b — — Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact.
qwen3.6-35b-a3b-mtp-q6 — — Replaced legacy SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across the test suite and removed unused container tests. Merged to master with no change in code coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1794379 SNAPCRAFT_PACKAGE_TYPE for tests snapcraft (launchpad) closed Track migrating integration tests from SNAPCRAFT_FROM_* vars to SNAPCRAFT_PACKAGE_TYPE for spread. Done by merged PR snapcore/snapcraft#2295 (commit ffbad69ea, 2018-09), which also removed unused container tests; author closed the bug with that PR link.
85%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename.
78%
#2793 tests: enable SNAPCRAFT_BUILD_INFO for spread snapcraft merged Merged as commit 12370aae1, enabling SNAPCRAFT_BUILD_INFO across Spread tests to exercise manifest generation and updating nil-basic for the resulting manifest.
75%
#2130 tests: remove obsolete env var snapcraft merged Merged PR #2130 as commit 5305ac01c, removing obsolete SNAPCRAFT_SEND_ERROR_DATA test configuration after the related error-data logic was removed.
74%
#2096 tests: don't use os_release and repo from snapcraft snapcraft merged Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982.
73%
#386 tests: update testing to use craft-test fetch-service merged Merged #386 as commit 323b0e1, replacing direct Spread calls with snapcraft test and updating the test base to core24.
73%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
73%
#2353 tests: remove dependency on snapcraft for integration tests snapcraft merged PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup.
73%
#1372 cli: Containerbuild clean snapcraft merged Merged #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1.
73%
#1894 tests: allow to overwrite the snapcraft install command snapcraft merged Merged PR #1894 as commit 596896be8, adding SNAPCRAFT_INSTALL_COMMAND so integration tests can override Snapcraft installation and skip the preceding build stage.
72%