tests: remove obsolete env var
Metadata
Current evaluation
Merged PR #2130 as commit 5305ac01c, removing obsolete SNAPCRAFT_SEND_ERROR_DATA test configuration after the related error-data logic was removed.
Resolution: closed resolved
Reason: PR #2130 was approved without unresolved comments and merged as commit 5305ac01c. Its four-line deletion removed the obsolete test environment variable.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Logic around `SNAPCRAFT_SEND_ERROR_DATA` has been removed so it makes little
sense to keep it for tests.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2130 as commit 5305ac01c, removing obsolete SNAPCRAFT_SEND_ERROR_DATA test configuration after the related error-data logic was removed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2130 as commit 5305ac01c, removing obsolete SNAPCRAFT_SEND_ERROR_DATA test configuration after its underlying error-data logic was removed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2130 (commit 5305ac01c), removing the obsolete SNAPCRAFT_SEND_ERROR_DATA variable from tests after its runtime logic was deleted. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests after the underlying logic was deleted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1996 tests: add SNAPCRAFT_KEEP_DATA to debug | snapcraft | merged | Merged PR #1996 added SNAPCRAFT_KEEP_DATA_PATH support to retain integration-test data for debugging; landed as commit 0024c35ff. | |
| #2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere | snapcraft | merged | PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379) | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged PR #2421 in commit 707395546, deleting 77 obsolete snap/external-test files and 2,959 lines despite a negligible coverage decrease. |