← Back to issue list

tests: remove obsolete env var

View original Github issue

Metadata

Project
snapcraft
Number
#2130
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file.

Suggested action:

No scores available.

Issue body

Logic around `SNAPCRAFT_SEND_ERROR_DATA` has been removed so it makes little sense to keep it for tests. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests after the underlying logic was deleted.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following deletion of the underlying error reporting logic.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1996 tests: add SNAPCRAFT_KEEP_DATA to debug snapcraft merged Merged test updates adding the SNAPCRAFT_KEEP_DATA environment variable for debugging. Approved by two reviewers, the change modifies two files with a net addition of 14 lines. Submitted as a farewell gift to @sergiusens.
81%
#564 fix(test): remove env var set by snapped testing programs craft-application merged Merged a fix for test failures caused by the SNAP_INSTANCE_NAME environment variable during snapped execution. The change removes it before tests to ensure consistent behavior. Approved by two reviewers and passed CI checks.
74%
#2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere snapcraft merged Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact.
73%
#2179 cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated snapcraft merged Merged into master after approval and CI. Fixed a misleading deprecation warning that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT instead of SNAPCRAFT_CONTAINER_BUILDS. Updated two lines to correct the error message.
73%
#2122 many: introduce variables for part src and build snapcraft merged Merged following approval. Introduces new environment variables and replacements for part src and build directories, resolving LP #1763028. Consolidates SNAPCRAFT_* environment handling into a single location. Approved by one reviewer with passing CI checks.
71%
#4041 utils: log envvar SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT when invalid snapcraft merged Merged into main. Adds logging for the SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable when invalid. Approved by reviewer, passed CI, and contains no functional changes.
71%