pluginhandler: correctly dedent the run script
Metadata
Current evaluation
Merged fix to correctly dedent the pluginhandler run script. Passes CI checks and serves as prework for improved error output, partially addressing Launchpad bug #1767625.
Suggested action: —
No scores available.
Issue body
LP: #1767625
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix to correctly dedent the pluginhandler run script. Passes CI checks and serves as prework for improved error output, partially addressing Launchpad bug #1767625. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change to correctly dedent the run script in pluginhandler. The author notes this serves as prework for improved error output rather than a complete fix for Launchpad bug #1767625. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to correctly dedent the run script in pluginhandler. The author notes this is prework for improved error output rather than a complete resolution. The change was integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1545 pluginhandler: error out on scriptlet errors | snapcraft | merged | Merged fix ensuring scriptlet errors trigger immediate failures instead of only catching the last command's error. Approved by one reviewer, passed CI, and merged by maintainer sergiusens. Resolves Launchpad bug #1707189. | |
| #1405 pluginhandler: check for collisions only in existing files | snapcraft | merged | Merged to resolve Launchpad bug #1660696 by updating the pluginhandler to check for collisions only in existing files. Approved by two reviewers, the change modifies six files with 45 additions and 4 deletions. | |
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage. |