pluginhandler: correctly dedent the run script
Metadata
Current evaluation
Merged PR #2117 via commit fb5f57a7d, correctly dedenting pluginhandler run-script output as partial prework for LP #1767625.
Resolution: closed resolved
Reason: PR #2117 was merged as commit fb5f57a7d, correcting run-script indentation and improving error output. The maintainer noted that LP #1767625 was not fully solved by this prework.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1767625
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2117 via commit fb5f57a7d, correctly dedenting pluginhandler run-script output as partial prework for LP #1767625. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2117 (commit fb5f57a7d) correctly dedented the pluginhandler run script, improving error output but only partially fixing Launchpad bug #1767625. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix to correctly dedent the pluginhandler run script. Passes CI checks and serves as prework for improved error output, partially addressing Launchpad bug #1767625. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change to correctly dedent the run script in pluginhandler. The author notes this serves as prework for improved error output rather than a complete fix for Launchpad bug #1767625. |
Update history
No update history recorded yet.
Related work
-
Related To:
launchpad#1767625
(confidence 99%)
The PR explicitly addresses this bug only partially.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #987 pluginhandler: prepare scriptlet support | snapcraft | merged | Merged into master as commit 5671b910b, reworking pluginhandler to prepare for scriptlet support (LP #1642371). It set up the plumbing so the follow-up PR #988 (cc123cad9) could add build-scriptlet handling. | |
| #960 pluginhandler: install scriptlet support | snapcraft | merged | Merged PR #960 (commit eb9f74b4) added pluginhandler support for part install scriptlets, implementing LP #1649683. Follow-up merged PRs #987 and #988 added prepare/build scriptlets. | |
| #1545 pluginhandler: error out on scriptlet errors | snapcraft | merged | Merged pluginhandler now fails on any scriptlet command error, not only the final command, fixing LP #1707189; PR snapcraft#1545 landed as commit 3a18cc87a. | |
| #988 pluginhandler: build scriptlet support | snapcraft | merged | Merged PR #988 added pluginhandler build-scriptlet support for custom part build scripts in commit cc123cad9. |