pluginhandler: prepare scriptlet support
Metadata
Current evaluation
Merged into master as commit 5671b910b, reworking pluginhandler to prepare for scriptlet support (LP #1642371). It set up the plumbing so the follow-up PR #988 (cc123cad9) could add build-scriptlet handling.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit 5671b910b ("pluginhandler: prepare scriptlet support (#987)"), landing alongside the preceding install-scriptlet PR #960 and the follow-up build-scriptlet PR #988 (cc123cad9).
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into master as commit 5671b910b, reworking pluginhandler to prepare for scriptlet support (LP #1642371). It set up the plumbing so the follow-up PR #988 (cc123cad9) could add build-scriptlet handling. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master as 5671b910b, preparing pluginhandler for scriptlet support; follow-up #988 added build-scriptlet handling. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master after reviewer approval. The change prepares scriptlet support in the pluginhandler, modifying 7 files (+77/-10 lines). Code coverage increased by less than 0.01% upon integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master to prepare the pluginhandler for scriptlet support. The change increased code coverage by less than 0.01% and passed automated validation. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#988
(confidence 95%)
Follow-up PR completing the scriptlet work by adding build-scriptlet support in pluginhandler (commit cc123cad9).
-
Related To:
snapcraft#960
(confidence 80%)
Immediately preceding PR 'pluginhandler: install scriptlet support' (commit eb9f74b4a), the base commit for this PR's codecov comparison.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #960 pluginhandler: install scriptlet support | snapcraft | merged | Merged PR #960 (commit eb9f74b4) added pluginhandler support for part install scriptlets, implementing LP #1649683. Follow-up merged PRs #987 and #988 added prepare/build scriptlets. | |
| #988 pluginhandler: build scriptlet support | snapcraft | merged | Merged PR #988 added pluginhandler build-scriptlet support for custom part build scripts in commit cc123cad9. | |
| #2327 pluginhandler: remove prepare, build and install scriptlets | snapcraft | merged | Merged PR #2327 removed PluginHandler's deprecated prepare, build, and install scriptlets, retaining override-{step-name} handling and compatibility tests. | |
| #2117 pluginhandler: correctly dedent the run script | snapcraft | merged | Merged PR #2117 via commit fb5f57a7d, correctly dedenting pluginhandler run-script output as partial prework for LP #1767625. | |
| #1545 pluginhandler: error out on scriptlet errors | snapcraft | merged | Merged pluginhandler now fails on any scriptlet command error, not only the final command, fixing LP #1707189; PR snapcraft#1545 landed as commit 3a18cc87a. | |
| #1998 pluginhandler: add {pre,post}-build scriptlets | snapcraft | closed | Closed unmerged; its pre-/post-build rename was superseded by #2002 (bbca282fa), which introduced snapcraftctl and override-build. |