← Back to issue list

pluginhandler: build scriptlet support

View original Github issue

Metadata

Project
snapcraft
Number
#988
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #988 added pluginhandler build-scriptlet support for custom part build scripts in commit cc123cad9.

Resolution: closed resolved

Reason: PR #988 was merged as commit cc123cad9. The change added pluginhandler support for part build scriptlets and addressed LP #1649684.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1649684 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #988 added pluginhandler build-scriptlet support for custom part build scripts in commit cc123cad9.
stealth/space-bunny-alpha — closed resolved Merged PR #988 (commit cc123cad9) added pluginhandler build-scriptlet support, implementing the requested custom part build scripts.
qwen/qwen3.6-35b-a3b — — Merged pull request adding build scriptlet support to the pluginhandler. The update modifies 8 files with 96 additions and 9 deletions, resolving LP #1649684.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes adding build scriptlet support to the pluginhandler module. Resolves Launchpad bug #1649684. Approved and integrated by maintainer sergiusens without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#960 pluginhandler: install scriptlet support snapcraft merged Merged PR #960 (commit eb9f74b4) added pluginhandler support for part install scriptlets, implementing LP #1649683. Follow-up merged PRs #987 and #988 added prepare/build scriptlets.
87%
#987 pluginhandler: prepare scriptlet support snapcraft merged Merged into master as commit 5671b910b, reworking pluginhandler to prepare for scriptlet support (LP #1642371). It set up the plumbing so the follow-up PR #988 (cc123cad9) could add build-scriptlet handling.
85%
#2327 pluginhandler: remove prepare, build and install scriptlets snapcraft merged Merged PR #2327 removed PluginHandler's deprecated prepare, build, and install scriptlets, retaining override-{step-name} handling and compatibility tests.
73%
#1998 pluginhandler: add {pre,post}-build scriptlets snapcraft closed Closed unmerged; its pre-/post-build rename was superseded by #2002 (bbca282fa), which introduced snapcraftctl and override-build.
73%
#1545 pluginhandler: error out on scriptlet errors snapcraft merged Merged pluginhandler now fails on any scriptlet command error, not only the final command, fixing LP #1707189; PR snapcraft#1545 landed as commit 3a18cc87a.
70%
#2117 pluginhandler: correctly dedent the run script snapcraft merged Merged PR #2117 via commit fb5f57a7d, correctly dedenting pluginhandler run-script output as partial prework for LP #1767625.
70%