pluginhandler: install scriptlet support
Metadata
Current evaluation
Merged PR #960 (commit eb9f74b4) added pluginhandler support for part install scriptlets, implementing LP #1649683. Follow-up merged PRs #987 and #988 added prepare/build scriptlets.
Resolution: closed resolved
Reason: PR #960 was approved and merged into master as commit eb9f74b4 ("pluginhandler: install scriptlet support"), adding install-scriptlet plumbing in the plugin handler for LP #1649683. Docs were noted as pending in review and landed shortly after.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #960 (commit eb9f74b4) added pluginhandler support for part install scriptlets, implementing LP #1649683. Follow-up merged PRs #987 and #988 added prepare/build scriptlets. | |
| stealth/space-bunny-alpha | — | closed resolved | Added pluginhandler support for install scriptlets in merged PR #960 via commit eb9f74b4, addressing LP #1649683. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master, adding install scriptlet support to the pluginhandler. The change passed review and CI, increased coverage by 0.01%, and included updated documentation. The change modified 9 files with 279 additions and 101 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, implementing install scriptlet support in the pluginhandler. Code coverage increased by 0.01%. Documentation was added per reviewer request, with site deployment confirmed. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#987
(confidence 85%)
Merged follow-up PR adding prepare scriptlet support (commit 5671b910b) as part of the same pluginhandler scriptlet work.
-
Related To:
snapcraft#988
(confidence 85%)
Merged follow-up PR adding build scriptlet support (commit cc123cad9), completing the prepare/build/install scriptlet set.
-
Related To:
snapcraft#2327
(confidence 60%)
Later commit c6542b5f7 removed prepare, build and install scriptlets, so this feature was eventually decommissioned.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #987 pluginhandler: prepare scriptlet support | snapcraft | merged | Merged into master as commit 5671b910b, reworking pluginhandler to prepare for scriptlet support (LP #1642371). It set up the plumbing so the follow-up PR #988 (cc123cad9) could add build-scriptlet handling. | |
| #988 pluginhandler: build scriptlet support | snapcraft | merged | Merged PR #988 added pluginhandler build-scriptlet support for custom part build scripts in commit cc123cad9. | |
| #2327 pluginhandler: remove prepare, build and install scriptlets | snapcraft | merged | Merged PR #2327 removed PluginHandler's deprecated prepare, build, and install scriptlets, retaining override-{step-name} handling and compatibility tests. | |
| #1545 pluginhandler: error out on scriptlet errors | snapcraft | merged | Merged pluginhandler now fails on any scriptlet command error, not only the final command, fixing LP #1707189; PR snapcraft#1545 landed as commit 3a18cc87a. | |
| #2117 pluginhandler: correctly dedent the run script | snapcraft | merged | Merged PR #2117 via commit fb5f57a7d, correctly dedenting pluginhandler run-script output as partial prework for LP #1767625. | |
| #1998 pluginhandler: add {pre,post}-build scriptlets | snapcraft | closed | Closed unmerged; its pre-/post-build rename was superseded by #2002 (bbca282fa), which introduced snapcraftctl and override-build. | |
| #1618 states: add scriptlets to build state | snapcraft | merged | Merged PR #1618 (commit 4355d3ac1) adds prepare/build/install scriptlets to the build state so changing them marks the part dirty, fixing LP bug #1672407. |