← Back to issue list

Backport to 1.x: Catkin plugin: Refactor build.

View original Github issue

Metadata

Project
snapcraft
Number
#184
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling.

Resolution: closed resolved

Reason: Merged PR #184 completed the 1.x backport of PR #175, whose refactor is recorded in commit 9045874fd. The three-file change updated the Catkin plugin and its tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #175 to 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#184 backported #175’s Catkin build refactor to the 1.x branch, updating three files (+664/−369) to simplify build logic and dependency resolution.
qwen/qwen3.6-35b-a3b — — Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged the backport of PR #175 to the 1.x branch, applying the Catkin plugin build refactoring.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#175 (confidence 100%)

    Original merged Catkin build refactor backported by PR #184.

Related issues

Issue Project State Summary Similarity
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory.
86%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies.
83%
#180 Backport to 1.x: Catkin plugin: Add support for ROS tools. snapcraft merged Merged #180, backporting #152 to the 1.x branch to add ROS tools support to the Catkin plugin.
80%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.
78%
#175 Catkin plugin: Refactor build. snapcraft merged Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests.
75%
#219 Backport to 1.x: Replace use of `assert_not_called` in the catkin tests snapcraft merged Merged into 1.x as PR #219, backporting #200 to replace assert_not_called() with assertFalse(mock.called) in catkin tests while preserving custom failure messages.
71%
#292 Backport to 1.x: Fix ordering for conditional negations in catkin tests snapcraft merged Merged into snapcraft 1.x via PR #292, backporting PR #199’s two-line fix for conditional-negation ordering in catkin tests.
71%