pluginhandler: remove prepare, build and install scriptlets
Metadata
Current evaluation
Merged PR #2327 removed PluginHandler's deprecated prepare, build, and install scriptlets, retaining override-{step-name} handling and compatibility tests.
Resolution: closed resolved
Reason: PR #2327 was merged as commit c6542b5f7, removing the deprecated scriptlets in favor of the override-{step-name} syntax. Integration tests remain to verify backward compatibility.
Evaluated by: mr-cal-bot
No scores available.
Issue body
These have long since been deprecated in favour of the
override-{step-name} syntax.
The integration tests remain to ensure backwards compatibility is in
order.
LP: #1794854
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2327 removed PluginHandler's deprecated prepare, build, and install scriptlets, retaining override-{step-name} handling and compatibility tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2327 (commit c6542b5f7): removed deprecated prepare, build, and install scriptlets in favor of override-{step-name}; integration tests preserve backward compatibility. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2327 (commit c6542b5f7), removing deprecated prepare, build, and install scriptlets in favor of override-step-name syntax. Backward compatibility remains covered by integration tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler, replaced by override-step-name syntax. Backwards compatibility maintained via integration tests. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler in favor of override-step-name syntax. Integration tests retained for backwards compatibility. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #960 pluginhandler: install scriptlet support | snapcraft | merged | Merged PR #960 (commit eb9f74b4) added pluginhandler support for part install scriptlets, implementing LP #1649683. Follow-up merged PRs #987 and #988 added prepare/build scriptlets. | |
| #987 pluginhandler: prepare scriptlet support | snapcraft | merged | Merged into master as commit 5671b910b, reworking pluginhandler to prepare for scriptlet support (LP #1642371). It set up the plumbing so the follow-up PR #988 (cc123cad9) could add build-scriptlet handling. | |
| #1794854 Remove deprecated scriptlets | snapcraft (launchpad) | closed | Deprecated prepare, build, and install scriptlets were removed; only override-* scriptlets remain. Fixed by PR #2327, commit c6542b5f7. | |
| #988 pluginhandler: build scriptlet support | snapcraft | merged | Merged PR #988 added pluginhandler build-scriptlet support for custom part build scripts in commit cc123cad9. | |
| #1998 pluginhandler: add {pre,post}-build scriptlets | snapcraft | closed | Closed unmerged; its pre-/post-build rename was superseded by #2002 (bbca282fa), which introduced snapcraftctl and override-build. |