pluginhandler: remove prepare, build and install scriptlets
Metadata
Current evaluation
Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler, replaced by override-step-name syntax. Backwards compatibility maintained via integration tests. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
These have long since been deprecated in favour of the
override-{step-name} syntax.
The integration tests remain to ensure backwards compatibility is in
order.
LP: #1794854
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler, replaced by override-step-name syntax. Backwards compatibility maintained via integration tests. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler in favor of override-step-name syntax. Integration tests retained for backwards compatibility. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler, replaced by override-step-name syntax. Integration tests preserved for backwards compatibility. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #960 pluginhandler: install scriptlet support | snapcraft | merged | Merged into master, adding install scriptlet support to the pluginhandler. The change passed review and CI, increased coverage by 0.01%, and included updated documentation. The change modified 9 files with 279 additions and 101 deletions. | |
| #987 pluginhandler: prepare scriptlet support | snapcraft | merged | Merged into master after reviewer approval. The change prepares scriptlet support in the pluginhandler, modifying 7 files (+77/-10 lines). Code coverage increased by less than 0.01% upon integration. | |
| #988 pluginhandler: build scriptlet support | snapcraft | merged | Merged pull request adding build scriptlet support to the pluginhandler. The update modifies 8 files with 96 additions and 9 deletions, resolving LP #1649684. | |
| #3126 pluginhandler: allow cleaning the build step | snapcraft | merged | Merged fix resolving PluginV2 part cleanup failures caused by an improper guard in the clean_build method. Approved by reviewer, passed CI, and integrated into the codebase. | |
| #1998 pluginhandler: add {pre,post}-build scriptlets | snapcraft | closed | Closed without merging. The author indicated plans to restructure the changes and implement them in a different order, superseding this pull request. | |
| #2329 pluginhandler: remove legacy plugin loading without project | snapcraft | merged | Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase. |