← Back to issue list

schema, meta: support app command-chain

View original Github issue

Metadata

Project
snapcraft
Number
#2341
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #2341 merged into master as commit 194989b4e, adding snapcraft.yaml schema and snap metadata (meta/snap_yaml.py) support for per-app command-chain, resolving LP bug #1790978.

Resolution: closed resolved

Reason: The PR was approved and merged into master as commit 194989b4e ("schema, meta: support app command-chain (#2341)"), which the PR body states resolves LP #1790978. The support is still present in the codebase today: schema/snapcraft.json defines "command-chain" for apps and meta/snap_yaml.py adds the command-chain assume.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1790978](https://bugs.launchpad.net/snapcraft/+bug/1790978) by adding support for specifying command-chain. This is only available in snapd v2.36, but more features depend on this one, so we need to add support now.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2341 merged into master as commit 194989b4e, adding snapcraft.yaml schema and snap metadata (meta/snap_yaml.py) support for per-app command-chain, resolving LP bug #1790978.
stealth/space-bunny-alpha — closed resolved Merged PR #2341 as commit 194989b4e, adding schema and metadata support for app command-chain and resolving LP #1790978. Requires snapd 2.36 or later.
stealth/space-bunny-alpha — closed resolved Merged PR #2341 (commit 194989b4e) added schema + meta support for `command-chain` on apps, resolving LP #1790978. Requires snapd v2.36; follow-up #2343 added the "full" adapter using it.
stealth/space-bunny-alpha — closed resolved Merged #2341 as commit 194989b4e, adding app command-chain schema and metadata support for snapd 2.36+ and resolving LP #1790978.
stealth/space-bunny-alpha — closed resolved Merged PR #2341 (commit 194989b4e) by kyrofa adds schema and meta support for the app `command-chain` key, resolving LP bug #1790978. Feature requires snapd v2.36+.
stealth/space-bunny-alpha — closed resolved Merged #2341 in commit 194989b4e, adding schema and metadata support for app command-chain and resolving LP #1790978. Requires snapd v2.36 or later.
qwen/qwen3.6-35b-a3b — — Merged into master, implementing schema and meta support for app command-chain to resolve LP #1790978. Requires snapd v2.36+. Approved, passed CI, and increased code coverage by 0.01%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Adds schema and meta support for app command-chain, resolving LP #1790978. Requires snapd v2.36+. Achieved 94.73% diff coverage.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2343 (confidence 82%)

    Follow-on merged PR (commit d99c1fe43) adding the "full" app adapter, which depends on command-chain support landing first.

  • Related To: canonical/snapcraft#2375 (confidence 72%)

    Later PR (commit 57c7fb8d0) adding a sanity check that command-chain is not combined with the legacy adapter, extending this feature's validation.

  • Related To: canonical/snapcraft#2379 (confidence 65%)

    Later PR (commit 2b5a254ef) adding assumes for the "full" adapter, building on the command-chain support introduced here.

Related issues

Issue Project State Summary Similarity
#1790978 Add support for app command-chains snapcraft (launchpad) closed App-level command-chain support was merged in snapcraft PR #2341 (commit 194989b4e), adding schema and snap metadata handling and resolving LP #1790978.
86%
#1662240 post-stop-command not defined in snapcraft schema snapcraft (launchpad) closed Added app-level post-stop-command support via merged snapcraft PR #1109 (commit 392a310f2); field now exists in schema/snapcraft.json and is emitted in snap.yaml apps metadata, and the Launchpad bug was closed.
72%