nodejs plugin: add support for bases
Metadata
Current evaluation
Merged update adding base support to the Node.js plugin. Updates npm and yarn invocation to follow standard industry practices. Approved by two reviewers, passed CI, and modified 18 files.
Suggested action: —
No scores available.
Issue body
Invoke npm and yarn using normal industry practices.
LP: #1794796
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged update adding base support to the Node.js plugin. Updates npm and yarn invocation to follow standard industry practices. Approved by two reviewers, passed CI, and modified 18 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main branch. Adds bases support to the Node.js plugin, updating npm and yarn invocation to follow standard industry practices. Integration completed with 88.5% diff code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds bases support to the nodejs plugin and updates npm and yarn invocation to follow standard industry practices, resolving Launchpad bug #1794796. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2323 go plugin: support for bases | snapcraft | merged | Merged. Introduces base support to the Go plugin, prioritizing the Go snap from the Snap Store and enabling golang-go installation on supported bases. Approved by reviewer and passed all CI checks. | |
| #1245 nodejs plugin: add support for yarn. | snapcraft | merged | Added yarn support to the nodejs plugin. Approved by one reviewer, local tests passed, and the change was merged despite a Travis CI timeout. | |
| #2358 dotnet plugin: add support for bases | snapcraft | merged | Merged after reviewer approval, adding base awareness to the DotNet plugin for core16. Passed CI checks and achieved 100% diff coverage across 9 modified files. | |
| #2362 python plugin: add support for bases | snapcraft | merged | Merged. Updated the Python plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and migrated tests to spread with 97.36% coverage. | |
| #2370 ant plugin: add support for bases | snapcraft | merged | Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage. | |
| #2373 rust plugin: add support for bases | snapcraft | merged | Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files. | |
| #1794796 Update the nodejs plugin to be base aware | snapcraft (launchpad) | closed | Closed without comments or linked pull requests. The request to update the nodejs plugin for base awareness and split npm/yarn support appears abandoned or superseded. No resolution details were provided. | |
| #2346 ruby plugin: add support for base | snapcraft | merged | Updates the Ruby plugin to be base-aware, restricting support to core16 and core18. Resolves bug LP: #1794800. Merged after approval, passing CI, and 100% diff coverage. | |
| #2357 scons plugin: add support for bases | snapcraft | merged | Merged. Updated the Scons plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and modified 105 additions and 18 deletions across five files. | |
| #2372 gradle plugin: add support for bases | snapcraft | merged | Successfully merged update to the Gradle plugin, restricting base support to core16 and core18. Approved by reviewer, passed CI, and integrated with 448 additions and 108 deletions across 13 files. |