← Back to issue list

nodejs plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2356
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2356 as commit 3465f984f, making the Node.js plugin base-aware and updating npm and Yarn invocation to standard practices.

Resolution: closed resolved

Reason: PR #2356 merged as commit 3465f984f. The change added base-aware Node.js plugin behavior and resolved LP #1794796.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Invoke npm and yarn using normal industry practices. LP: #1794796 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2356 as commit 3465f984f, making the Node.js plugin base-aware and updating npm and Yarn invocation to standard practices.
stealth/space-bunny-alpha — closed resolved Merged PR snapcore/snapcraft#2356 as commit 3465f984f, adding base support to the Node.js plugin and adopting standard npm and yarn invocation practices.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft/snapcraft#2356 via commit 3465f984f, adding base support to the Node.js plugin and using standard npm and yarn invocation practices.
stealth/space-bunny-alpha — closed resolved Merged #2356 in commit 3465f984f, adding base support to the Node.js plugin and using standard npm and yarn invocation practices.
stealth/space-bunny-alpha — closed resolved Merged PR #2356 (commit 3465f984f), adding base support to the Node.js plugin and updating npm and yarn invocation to standard practices.
qwen/qwen3.6-35b-a3b — — Merged update adding base support to the Node.js plugin. Updates npm and yarn invocation to follow standard industry practices. Approved by two reviewers, passed CI, and modified 18 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main branch. Adds bases support to the Node.js plugin, updating npm and yarn invocation to follow standard industry practices. Integration completed with 88.5% diff code coverage.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1794796 Update the nodejs plugin to be base aware snapcraft (launchpad) closed Base-aware Node.js plugin support was merged in snapcore/snapcraft#2356 via commit 3465f984f, covering the npm/yarn plugin work requested by the issue.
77%
#2373 rust plugin: add support for bases snapcraft merged Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
75%
#2358 dotnet plugin: add support for bases snapcraft merged Merged PR #2358 as commit 58a06ef40, making the .NET plugin base-aware and limiting support to core16.
74%
#2346 ruby plugin: add support for base snapcraft merged Ruby plugin base support was merged into master via #2346 (commit bdb2b85e3), adding core16/core18 support and resolving LP #1794800.
74%
#102 NodeJS plugin snapcraft merged Merged PR #102 added the Node.js plugin; its initial implementation landed in commit 0336e05fb.
73%
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
72%
#2362 python plugin: add support for bases snapcraft merged Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread.
70%