remote-build: add initial command unit tests
Metadata
Current evaluation
PR #2785 by cjp256 merged into snapcraft master, adding initial unit tests for the remote-build command covering build-on arch handling; reviewer comments were addressed and the branch rebased.
Resolution: closed resolved
Reason: The PR was approved by a reviewer and merged, landing the new remote-build command tests in tests/unit (later renamed by commit 4f7f4a58a "chore: rename remote-build test (#4383)"). The author's follow-up comments confirm review feedback (use the existing fixture, resolve remaining issues) was addressed before merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add some tests test for `remote-build` and `build-on`
arch handling.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2785 by cjp256 merged into snapcraft master, adding initial unit tests for the remote-build command covering build-on arch handling; reviewer comments were addressed and the branch rebased. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2785 added initial unit tests for remote-build and build-on architecture handling; the author used the existing fixture and rebased after review. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after adding initial unit tests for remote-build and build-on architecture handling. Review requested using an existing fixture; author updated and rebased. CI passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged branch adding initial unit tests for remote-build and build-on architecture handling. Reviewer requested using an existing fixture; changes were rebased and merged. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4383
(confidence 70%)
Commit 4f7f4a58a renamed the test file added by this PR, confirming the tests landed in the tree.
-
Related To:
snapcraft#4368
(confidence 40%)
Follow-on remote-build work in the same area; the tests here predate the GitRepo/remote-build rewrite.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4382 tests: use less mocks in remote-build | snapcraft | merged | PR #4382 merged (commit 906834cda): remote-build unit tests no longer mock snapcraft.yaml loading but write and load real project files, prep for #4322. | |
| #2774 remote-build: architecture handling | snapcraft | merged | Merged PR #2774 via commit 8300281d6, cleaning up and fixing remote-build architecture handling. Missing CLI unit tests were acknowledged as follow-up work. | |
| #3076 remote-build: fix case where build log url is None | snapcraft | merged | Merged in snapcraft#3076 (commit 2c1dfe63c), fixing remote-build handling when the build log URL is absent and adding unit coverage. | |
| #299 fix(remote-build): minor edge cases found with snapcraft | craft-application | merged | Merged PR #299 fixed Snapcraft-related remote-build edge cases in three files, landing as commit 15087962 after two approvals. | |
| #2768 remote-build: autorecovery | snapcraft | merged | PR #2768 by cjp256 added autorecovery for `snapcraft remote-build` (retry/poll recovery of failed Launchpad builds), approved and merged as commit 0077d8265. | |
| #196 feat: remote build service | craft-application | merged | Merged PR #196 in commit e53de201, adding remote build service support and porting the latest remote-build implementation from Snapcraft. | |
| #3648 cli: reintroduce remote-build and promote to snapcraft help | snapcraft | merged | Merged PR #3648 (commit 8dc1ac016), restoring remote-build and promote in Snapcraft's main CLI help for Launchpad bug #1943244. | |
| #2638 remote-build rebased on 3.7 | snapcraft | closed | PR #2638 by cjp256 was a rebase of the remote-build branch onto snapcraft 3.7. Closed unmerged: sergiusens noted 3.7 was already on origin/remote-build, so the rebase was redundant and the author acknowledged. |