remote-build: add initial command unit tests
Metadata
Current evaluation
Merged after adding initial unit tests for remote-build and build-on architecture handling. Review requested using an existing fixture; author updated and rebased. CI passed.
Suggested action: —
No scores available.
Issue body
Add some tests test for `remote-build` and `build-on`
arch handling.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after adding initial unit tests for remote-build and build-on architecture handling. Review requested using an existing fixture; author updated and rebased. CI passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged branch adding initial unit tests for remote-build and build-on architecture handling. Reviewer requested using an existing fixture; changes were rebased and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after adding initial unit tests for remote-build and build-on architecture handling. Incorporated reviewer feedback by switching to an existing shared fixture and rebasing the branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2774 remote-build: architecture handling | snapcraft | merged | Merged architecture handling updates for remote-build. Modified one file with 36 additions and 30 deletions. Approved by one reviewer. Author noted missing CLI unit tests and plans a follow-up PR to address them. | |
| #5375 test: fix command tests | snapcraft | merged | Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions. | |
| #2642 remote-build: detect early build errors | snapcraft | merged | Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied. | |
| #769 feat: add the remote-build command | rockcraft | merged | Merged the remote-build command. Approved by three reviewers, the change adds 86 lines and removes 7 across nine files. Integrated by the maintainer without further comments or CI issues. | |
| #4660 refactor(test): versioned remote-build tests | snapcraft | merged | Merged test refactoring for versioned remote-build tests with no logic changes. Approved by two reviewers, zero unresolved comments, and passing CI. Codecov confirmed full coverage on modified lines. Successfully integrated. | |
| #1546 feat: remote build command | charmcraft | merged | Merged the remote build command feature. Approved by two reviewers and passing CI, the PR rebases prior work and adds remote build functionality. Follow-up issues were created to resolve related build-id recovery and dependency bugs. |