plugins: introduce v2.MakePlugin with rebuilding
Metadata
Current evaluation
Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines).
Suggested action: —
No scores available.
Issue body
Environment is now also properly setup.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Introduces v2.MakePlugin with rebuilding support and proper environment setup. Integrated into the main branch by maintainer sergiusens. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Introduces v2.MakePlugin with rebuilding support and proper environment setup. Integrated directly into the main branch without additional discussion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #33 plugins: add make plugin | craft-parts | merged | Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system. | |
| #3037 plugins: introduce v2.CMakePlugin | snapcraft | merged | Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions. | |
| #3069 make v2 plugin: make use of make-parameters | snapcraft | merged | Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase. | |
| #935 cmake plugin: utilize MakePlugin build logic within CMakePlugin | snapcraft | merged | Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter. | |
| #3059 plugins: introduce v2.MesonPlugin | snapcraft | merged | The v2.MesonPlugin feature was approved by one reviewer and successfully merged. The commit added 216 lines and removed 4 across 10 files, finalizing the new plugin implementation. | |
| #3081 make v2 plugin: also pass make-parameters to install | snapcraft | merged | Merged updates to the make v2 plugin to pass make-parameters to the install step. The change modified two files with 12 additions and 8 deletions, passed CI checks, received reviewer approval, and was successfully integrated. | |
| #3070 plugins v2: update plugins so they have a similar behavior | snapcraft | merged | Merged after reviewer approval and passing CI. Standardized plugin behavior by removing invalid minitems usage, eliminating prefix setup and default build type concepts, and correcting docstring formatting across 13 files. |