spread: update electron-builder test
Metadata
Current evaluation
Merged after approval by two reviewers and passing CI checks. Updates the electron-builder test in the spread testing framework, modifying two files to align test expectations.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval by two reviewers and passing CI checks. Updates the electron-builder test in the spread testing framework, modifying two files to align test expectations. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request by maintainer sergiusens to update the electron-builder test in the spread framework. The changes were accepted and integrated into the main branch without additional discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer sergiusens, the update to the electron-builder test in the spread configuration was accepted and integrated. No additional discussion or modifications were required. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3323 electron-builder spread test: sync expected snapcraft.yaml | snapcraft | merged | Merged to sync the expected snapcraft.yaml in the electron-builder spread test with upstream updates. Approved by one reviewer, updating one file with nine additions and one deletion. | |
| #3312 spread tests: introduce electron-builder test | snapcraft | merged | Merged test case for electron-builder with useTemplate false. Compares generated snapcraft and meta YAML files to track upstream updates. Approved, passed CI, and added 385 lines across 11 files. | |
| #3662 tests: update spread url | snapcraft | merged | Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #3663 tests: update spread url | snapcraft | merged | Merged following reviewer approval and passing CI. Updated spread tarball URLs in test configuration files, modifying two files with minimal changes. | |
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #62 spread: add a "big" spread test | rockcraft | merged | Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks. | |
| #4529 Spread update | snapcraft | merged | Merged after approval by two reviewers and passing CI checks. The update modifies spread configuration across three files, adding 36 and removing 40 lines. Code coverage tests passed. | |
| #143 docs: make docs spread-testable | craft-store | merged | Merged documentation spread-testing infrastructure setup. Approved by two reviewers and passing CI, the change modifies six files (+136/-41 lines) to enable local spread test execution for documentation. | |
| #3602 spread: switch to yarn for electron-builder test | snapcraft | merged | Merged to switch the electron-builder test runner from npm to yarn, following official documentation recommendations. Approved by a reviewer with passing CI checks and a five-line diff. |