← Back to issue list

spread: update electron-builder test

View original Github issue

Metadata

Project
snapcraft
Number
#3454
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3454 in commit d96e236f2, updating two electron-builder spread-test files so expected results matched current generation behavior.

Resolution: closed resolved

Reason: The approved PR was merged as commit d96e236f2. Its two-file change updated the electron-builder spread test expectations to reflect current output generation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3454 in commit d96e236f2, updating two electron-builder spread-test files so expected results matched current generation behavior.
stealth/space-bunny-alpha — closed resolved Merged #3454 as d96e236f2, updating two electron-builder spread-test files to match current generation behavior.
stealth/space-bunny-alpha — closed resolved Merged PR #3454 in commit d96e236f2, updating two electron-builder spread-test files to match current generation behavior.
stealth/space-bunny-alpha — closed resolved Merged PR #3454 (commit d96e236f2), updating two electron-builder spread-test files to align expected results with current generation behavior.
stealth/space-bunny-alpha — closed resolved Merged PR #3454 (commit d96e236f2) updated the spread electron-builder test, with approved changes to two test files.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers and passing CI checks. Updates the electron-builder test in the spread testing framework, modifying two files to align test expectations.
qwen3.6-35b-a3b-mtp-q6 — — Merged a pull request by maintainer sergiusens to update the electron-builder test in the spread framework. The changes were accepted and integrated into the main branch without additional discussion.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3312 (confidence 96%)

    PR #3312 originally introduced the electron-builder spread test updated here.

Related issues

Issue Project State Summary Similarity
#3323 electron-builder spread test: sync expected snapcraft.yaml snapcraft merged Merged PR #3323 in commit c9941b82d, syncing the electron-builder spread test’s expected snapcraft.yaml with upstream changes.
79%
#3944 tests: fix electron spread test snapcraft merged Merged PR #3944 (d9fd33a71) updated the Electron spread-test fixture to include TMPDIR, matching generated snap.yaml and fixing the failing test.
79%
#3602 spread: switch to yarn for electron-builder test snapcraft merged Merged PR #3602 switched the electron-builder spread test from npm to yarn; implementation commit 11d64951e was merged as b81550376.
77%
#3312 spread tests: introduce electron-builder test snapcraft merged Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test with snapcraft.yaml and meta/snap.yaml comparisons.
77%
#3662 tests: update spread url snapcraft merged Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70.
72%