← Back to issue list

electron-builder spread test: sync expected snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#3323
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged to sync the expected snapcraft.yaml in the electron-builder spread test with upstream updates. Approved by one reviewer, updating one file with nine additions and one deletion.

Suggested action:

No scores available.

Issue body

Upstream released new version which includes snapcraft.yaml changes. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to sync the expected snapcraft.yaml in the electron-builder spread test with upstream updates. Approved by one reviewer, updating one file with nine additions and one deletion.
qwen3.6-35b-a3b-mtp-q6 Merged to sync the expected snapcraft.yaml for electron-builder spread tests with upstream changes. Integrated by maintainer cjp256 without additional comments.
qwen3.6-35b-a3b-mtp-q6 Merged to sync the expected snapcraft.yaml for the electron-builder spread test, aligning with upstream updates. Approved and merged by maintainer cjp256.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3312 spread tests: introduce electron-builder test snapcraft merged Merged test case for electron-builder with useTemplate false. Compares generated snapcraft and meta YAML files to track upstream updates. Approved, passed CI, and added 385 lines across 11 files.
82%
#3454 spread: update electron-builder test snapcraft merged Merged after approval by two reviewers and passing CI checks. Updates the electron-builder test in the spread testing framework, modifying two files to align test expectations.
81%
#3944 tests: fix electron spread test snapcraft merged Merged a fix for a failing electron spread test. Updated the expected snap.yaml to include the TMPDIR environment variable, resolving a diff mismatch.
76%
#3602 spread: switch to yarn for electron-builder test snapcraft merged Merged to switch the electron-builder test runner from npm to yarn, following official documentation recommendations. Approved by a reviewer with passing CI checks and a five-line diff.
70%