← Back to issue list

electron-builder spread test: sync expected snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#3323
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3323 in commit c9941b82d, syncing the electron-builder spread test’s expected snapcraft.yaml with upstream changes.

Resolution: closed resolved

Reason: PR #3323 was approved and merged as commit c9941b82d, updating the expected test fixture to match electron-builder’s new snapcraft.yaml output.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Upstream released new version which includes snapcraft.yaml changes. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3323 in commit c9941b82d, syncing the electron-builder spread test’s expected snapcraft.yaml with upstream changes.
stealth/space-bunny-alpha — closed resolved Merged PR #3323, commit c9941b82d, to sync the electron-builder spread test’s expected snapcraft.yaml with upstream changes.
qwen/qwen3.6-35b-a3b — — Merged to sync the expected snapcraft.yaml in the electron-builder spread test with upstream updates. Approved by one reviewer, updating one file with nine additions and one deletion.
qwen3.6-35b-a3b-mtp-q6 — — Merged to sync the expected snapcraft.yaml for electron-builder spread tests with upstream changes. Integrated by maintainer cjp256 without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3312 spread tests: introduce electron-builder test snapcraft merged Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test with snapcraft.yaml and meta/snap.yaml comparisons.
83%
#3454 spread: update electron-builder test snapcraft merged Merged PR #3454 in commit d96e236f2, updating two electron-builder spread-test files so expected results matched current generation behavior.
79%
#3944 tests: fix electron spread test snapcraft merged Merged PR #3944 (d9fd33a71) updated the Electron spread-test fixture to include TMPDIR, matching generated snap.yaml and fixing the failing test.
76%
#3602 spread: switch to yarn for electron-builder test snapcraft merged Merged PR #3602 switched the electron-builder spread test from npm to yarn; implementation commit 11d64951e was merged as b81550376.
74%