← Back to issue list

spread: switch to yarn for electron-builder test

View original Github issue

Metadata

Project
snapcraft
Number
#3602
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3602 switched the electron-builder spread test from npm to yarn; implementation commit 11d64951e was merged as b81550376.

Resolution: closed resolved

Reason: PR #3602 was merged with implementation commit 11d64951e, resulting in merge commit b81550376. The change updates the electron-builder spread test to use yarn.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> ------- - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3602 switched the electron-builder spread test from npm to yarn; implementation commit 11d64951e was merged as b81550376.
stealth/space-bunny-alpha — closed resolved Merged PR #3602, switching the electron-builder spread test from npm to Yarn; merge commit b81550376 contains implementation commit 11d64951e.
stealth/space-bunny-alpha — closed resolved Merged PR #3602 (merge commit b81550376, commit 11d64951e): switches the spread electron-builder test from npm to yarn, the tool recommended by electron-builder docs. Reviewed and approved.
stealth/space-bunny-alpha — closed resolved Merged PR #3602, switching the electron-builder spread test from npm to yarn; merged as b81550376 with implementation commit 11d64951e.
stealth/space-bunny-alpha — closed resolved Merged PR #3602 switched the electron-builder test runner from npm to yarn, following electron-builder's recommended package manager.
qwen/qwen3.6-35b-a3b — — Merged to switch the electron-builder test runner from npm to yarn, following official documentation recommendations. Approved by a reviewer with passing CI checks and a five-line diff.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Replaced npm with yarn in the spread test configuration for electron-builder, aligning with official tool recommendations. Maintainer confirmed the dependency change and the update was successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3454 spread: update electron-builder test snapcraft merged Merged PR #3454 in commit d96e236f2, updating two electron-builder spread-test files so expected results matched current generation behavior.
77%
#3323 electron-builder spread test: sync expected snapcraft.yaml snapcraft merged Merged PR #3323 in commit c9941b82d, syncing the electron-builder spread test’s expected snapcraft.yaml with upstream changes.
74%
#3312 spread tests: introduce electron-builder test snapcraft merged Merged PR #3312 in commit 04f642ba9, adding an electron-builder useTemplate: false spread test with snapcraft.yaml and meta/snap.yaml comparisons.
73%