← Back to issue list

tests: import sort with isort

View original Github issue

Metadata

Project
snapcraft
Number
#3352
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #3352 merged as commit 195460f76, applying isort to test imports across 199 files (+313/-276), part of the isort rollout after config landed in #3344. isort was later replaced by ruff in #4012.

Resolution: closed resolved

Reason: The pull request was merged into snapcraft with commit 195460f76 ("tests: sort imports with isort (#3352)"), reviewed and approved by a maintainer. It followed the isort configuration merged in #3344 (56c471f29) and was complemented by sibling PRs #3351, #3353, #3354 and #3383; isort itself was later removed in "style: remove isort" (a00f1c439) after the ruff migration in #4012.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3352 merged as commit 195460f76, applying isort to test imports across 199 files (+313/-276), part of the isort rollout after config landed in #3344. isort was later replaced by ruff in #4012.
stealth/space-bunny-alpha — closed resolved Merged PR #3352 (commit 195460f76) applied isort to snapcraft's test imports, reordering 199 files (+313/-276). Part of the isort rollout started by #3344; isort was later dropped in commit a00f1c439 in favour of ruff.
stealth/space-bunny-alpha — closed resolved Merged PR #3352, applying isort to test imports across 199 files, adding 313 lines and removing 276.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. Applied isort to standardize import ordering across 199 test files, modifying 313 lines added and 276 removed.
qwen3.6-35b-a3b-mtp-q6 — — Merged updates to sort test imports using isort. The maintainer's changes passed static and unit tests and were accepted without comments.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#3344 (confidence 92%)

    Merged as 56c471f29, adding the Black-compatible isort configuration in pyproject that PR #3352 relies on.

  • Related To: canonical/snapcraft#3351 (confidence 88%)

    Sibling merged commit d79d79bd2 'storeapi: sort imports with isort' — same import-sorting campaign.

  • Related To: canonical/snapcraft#3353 (confidence 86%)

    Sibling merged commit 9abfb5071 'tools: sort imports with isort'.

  • Related To: canonical/snapcraft#3354 (confidence 86%)

    Sibling merged commit 59f915c5b 'cli: sort imports with isort'.

  • Related To: canonical/snapcraft#3383 (confidence 84%)

    Follow-up commit d2f318468 'static: isort remaining python files' completing the sweep.

  • Related To: canonical/snapcraft#2819 (confidence 70%)

    Earlier closed proposal for isort; its revised Black-compatible setup ultimately landed via #3344.

  • Related To: canonical/snapcraft#4012 (confidence 65%)

    Later linters migration to ruff (a6e7d5f9d), after which isort was removed (a00f1c439), superseding this work.

Related issues

Issue Project State Summary Similarity
#3354 cli: import sort with isort snapcraft merged Merged #3354 (59f915c5b): isort applied to the CLI package, reordering imports in 11 files (+22/-19). Part of the isort rollout started by #3344 and continued in #3351, #3352, #3353 and #3383.
78%
#3353 tools: import sort with isort snapcraft merged Merged as commit 9abfb5071: sorted imports with isort in snapcraft's tools/ files (+2/-5, 5 files), part of the repo-wide isort rollout started in #3344 alongside #3351, #3352, #3354 and #3383.
76%
#2819 isort: automatic formatting/sorting of imports snapcraft closed Closed unmerged; author agreed to wait for a Black-compatible isort release and drop tools/format-code.sh. Superseded by merged PR #3344 (56c471f29), with #3351–#3354 and #3383 re-sorting imports.
75%
#3351 storeapi: import sort with isort snapcraft merged Merged as commit d79d79bd2: applied isort to storeapi imports across 16 files (+27/-49), adding isort:skip directives in __init__.py to preserve ordering-sensitive imports. Part of an isort rollout started by #3344.
73%