project schema tests: ensure json format checkers are loaded
Metadata
Current evaluation
Merged a fix resolving project schema test failures when run individually. The change imports missing JSON format checkers and suppresses related warnings. Approved by one reviewer, passed CI, and applied with a minimal two-line change.
Suggested action: —
No scores available.
Issue body
Many of the tests would fail when not running the whole test suite.
This is because the json format checkers in project_loader._config
have not been loaded. Ensure this module is imported, and mark the
import to ignore related warnings.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix resolving project schema test failures when run individually. The change imports missing JSON format checkers and suppresses related warnings. Approved by one reviewer, passed CI, and applied with a minimal two-line change. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for failing project schema tests by ensuring JSON format checkers in project_loader._config are loaded via an import. The change resolves test isolation failures and suppresses related warnings. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Resolves isolated test failures by ensuring JSON format checkers in project_loader._config are imported before execution, with warnings suppressed. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3350 project loader, schema: add advanced grammar support for build-environment | snapcraft | merged | Merged into master. Adds advanced grammar support for build-environment to the project loader and schema. Approved by one reviewer with 90.9% diff coverage. A minor plainbox unit test failure was noted but did not block the merge. | |
| #2361 schema: remove deprecated plugin pull and build-properties | snapcraft | merged | Merged schema cleanup removing deprecated plugin pull and build-properties. Approved by reviewer, passed CI, and changed 5 files (+1/-115 lines). Resolves LP: #1796669. | |
| #3072 schema: minor tweaks/fixes for package-repositories | snapcraft | merged | Merged minor schema tweaks for package-repositories. Changes include grammar fixes, expanded test coverage for empty fields, corrected test assertions, and removed an unnecessary name validation. Approved by one reviewer and passed CI checks. | |
| #781 feat: JSON schema generation for parts | craft-parts | merged | Merged the feature adding JSON schema generation for parts. Approved by two reviewers and depends on #778. The commit updates 13 files with 400 additions and 9 deletions. |