← Back to issue list

Backport to 1.x: CMake plugin: Automatically find staged libs and files.

View original Github issue

Metadata

Project
snapcraft
Number
#347
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged into 1.x as snapcraft#347, backporting #345 so the CMake plugin automatically locates staged libraries and files.

Resolution: closed resolved

Reason: PR #347 was merged into the 1.x branch. It backported #345, whose implementation commit 1673a17a5 added automatic CMake discovery of staged libraries and files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #345 to 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into 1.x as snapcraft#347, backporting #345 so the CMake plugin automatically locates staged libraries and files.
stealth/space-bunny-alpha — closed resolved Merged into 1.x as snapcraft#347, backporting #345 so the CMake plugin automatically locates staged libraries and files.
stealth/space-bunny-alpha — closed resolved Merged into 1.x as canonical/snapcraft#347, backporting #345 to make the CMake plugin automatically locate staged libraries and files.
qwen/qwen3.6-35b-a3b — — Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files. Python linting indentation issues were corrected prior to merge.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#345 (confidence 100%)

    Original implementation merged via 1673a17a5 and merge commit a0ba21e76; #347 backported it to 1.x.

Related issues

Issue Project State Summary Similarity
#345 CMake plugin: Automatically find staged libs and files. snapcraft merged CMake staged-library discovery was merged in canonical/snapcraft#345 via a0ba21e76 (implementation 1673a17a5), setting search environment variables so staged libs and files are found; fixes LP #1550778.
77%
#254 Backport to 1.x: Autotools plugin: Call make before make install snapcraft merged Merged snapcraft#254 into 1.x, backporting #253 so the Autotools plugin runs make before make install.
76%
#1550778 CMake plugin: Enable find_library etc. to find in stage directory snapcraft (launchpad) closed CMake staged-library discovery was merged in canonical/snapcraft#345 (commits 1673a17a5 and a0ba21e76), resolving LP #1550778.
75%
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory.
73%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.
71%