← Back to issue list

Backport to 1.x: CMake plugin: Automatically find staged libs and files.

View original Github issue

Metadata

Project
snapcraft
Number
#347
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.

Suggested action:

No scores available.

Issue body

Backport of #345 to 1.x.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.
qwen3.6-35b-a3b-mtp-q6 Merged backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files. Python linting indentation issues were corrected prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files. A PEP8 indentation error in the test suite was resolved prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35).
76%
#265 Backport to 1.x: Make plugin: Support non-standard makefile name. snapcraft merged Merged backport of #264 to the 1.x branch, adding support for non-standard makefile names in the Make plugin. Integration test conflicts were resolved to match 1.x plainbox types. The change modifies 7 files.
74%
#254 Backport to 1.x: Autotools plugin: Call make before make install snapcraft merged Merged backport of #253 to the 1.x branch, fixing the Autotools plugin to execute make before make install. The 2-file change passed CI and resolved the build sequence issue.
74%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.
74%
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
72%
#345 CMake plugin: Automatically find staged libs and files. snapcraft merged Merged. Updated the CMake plugin to automatically locate staged libraries and files using environment variables, resolving Launchpad bug #1550778. Approved by @sergiusens.
71%