← Back to issue list

Backport to 1.x: Autotools plugin: Call make before make install

View original Github issue

Metadata

Project
snapcraft
Number
#254
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcraft#254 into 1.x, backporting #253 so the Autotools plugin runs make before make install.

Resolution: closed resolved

Reason: PR #254 was merged into the 1.x branch. It backports the Autotools fix from PR #253, committed as bc2213122.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #253 for 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcraft#254 into 1.x, backporting #253 so the Autotools plugin runs make before make install.
stealth/space-bunny-alpha — closed resolved Merged snapcraft#254 into 1.x, backporting #253 so the Autotools plugin runs make before make install.
qwen/qwen3.6-35b-a3b — — Merged backport of #253 to the 1.x branch, fixing the Autotools plugin to execute make before make install. The 2-file change passed CI and resolved the build sequence issue.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #253 to the 1.x branch. The Autotools plugin now executes make before make install to correct the build sequence.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#253 (confidence 100%)

    Original merged fix that PR #254 backported to the 1.x branch.

Related issues

Issue Project State Summary Similarity
#352 Backport to 1.x: Autotools plugin: Support installing via prefix. snapcraft merged Merged into Snapcraft 1.x, adding prefix-based installation to the Autotools plugin as a backport of #351.
80%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged into 1.x as snapcraft#347, backporting #345 so the CMake plugin automatically locates staged libraries and files.
76%
#208 Backport to 1.x: Autotools plugin: Set autogen.sh executable. snapcraft merged Merged into 1.x: PR #208 backported #206, making the Autotools plugin set autogen.sh executable and adding tests.
76%
#1536700 autotools plugin doesn't call make snapcraft (launchpad) closed autotools plugin skipped the build step, running only `make install`. Fixed by canonical/snapcraft PR #253 ("Autotools plugin: Call make before make install"), merged as commit e09cdb58b.
72%
#1018 autotools: extend Make plugin instead of repeating code snapcraft closed Closed after inactivity; the same Autotools-to-Make plugin refactor was re-proposed in snapcraft#1076 and merged as commit 83072a5b2.
71%
#1659363 Autotools plugin should inherit make snapcraft (launchpad) closed Superseded by canonical/snapcraft#1076, which merged the Autotools-to-Make plugin refactor in commit 83072a5b2 after #1018 became inactive.
70%