← Back to issue list

Backport to 1.x: Autotools plugin: Call make before make install

View original Github issue

Metadata

Project
snapcraft
Number
#254
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged backport of #253 to the 1.x branch, fixing the Autotools plugin to execute make before make install. The 2-file change passed CI and resolved the build sequence issue.

Suggested action:

No scores available.

Issue body

Backport of #253 for 1.x.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged backport of #253 to the 1.x branch, fixing the Autotools plugin to execute make before make install. The 2-file change passed CI and resolved the build sequence issue.
qwen3.6-35b-a3b-mtp-q6 Merged backport of PR #253 to the 1.x branch. The Autotools plugin now executes make before make install to correct the build sequence.
qwen3.6-35b-a3b-mtp-q6 Merged backport of PR #253 to the 1.x branch. The Autotools plugin now explicitly runs make before make install, correcting the build sequence and ensuring proper package installation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#208 Backport to 1.x: Autotools plugin: Set autogen.sh executable. snapcraft merged Merged backport of #206 to the 1.x branch. The change sets autogen.sh as executable in the Autotools plugin, updating two files with 174 additions and one deletion.
79%
#352 Backport to 1.x: Autotools plugin: Support installing via prefix. snapcraft merged Merged to 1.x, backporting PR #351 to allow the Autotools plugin to install via a custom prefix. Changes span two files with 120 additions and 7 deletions.
78%
#265 Backport to 1.x: Make plugin: Support non-standard makefile name. snapcraft merged Merged backport of #264 to the 1.x branch, adding support for non-standard makefile names in the Make plugin. Integration test conflicts were resolved to match 1.x plainbox types. The change modifies 7 files.
77%
#253 Autotools plugin: Call make before make install snapcraft merged Merged a fix for the Autotools plugin to run make before make install, resolving Launchpad bug 1536700. Updated two files with seven additions and three deletions. Reviewer approved without requiring extra integration tests.
76%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.
74%
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
70%