export-login: clarify use of exported tokens
Metadata
Current evaluation
Merged clarification on exported token usage in export-login. Updated two files (+50/-3 lines). CI passed with 100% diff coverage. Unrelated upload failures and a minor coverage drop did not block the merge.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1145
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged clarification on exported token usage in export-login. Updated two files (+50/-3 lines). CI passed with 100% diff coverage. Unrelated upload failures and a minor coverage drop did not block the merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Clarifies exported token usage in the export-login module. Achieved 100% diff coverage despite a minor overall drop. Unrelated upload failures were noted. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Clarifies exported token usage in the export-login module. Codecov noted a negligible overall coverage drop but confirmed 100% diff coverage. Successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3797 store: export-login with legacy | snapcraft | merged | Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage. | |
| #3808 store: login requires no exported credentials | snapcraft | merged | Merged into main following reviewer approval and passing CI. The update modifies store login to require no exported credentials, changing 3 files (+29/-4 lines). Code coverage increased by 0.01% with 100% diff coverage. | |
| #6302 fix: error when export-login target file already exists | snapcraft | merged | Fixes an internal error when running export-login twice to the same file. Currently under review with one approval and three unresolved comments. CI passes on most platforms but fails on Ubuntu 22.04/26.04 integration tests and security scans. |