lint: lint legacy code with flake8
Metadata
Current evaluation
Merged into main following approval and passing CI. The change applies flake8 linting to legacy code across 17 files, modifying 31 additions and 36 deletions. Code coverage remains unchanged.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
lint legacy code with flake8
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main following approval and passing CI. The change applies flake8 linting to legacy code across 17 files, modifying 31 additions and 36 deletions. Code coverage remains unchanged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Applied flake8 linting to legacy code. Code coverage remained unchanged at 88.16%. Integrated by maintainer mr-cal. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Applied flake8 linting to legacy code. Codecov reported no coverage change upon merge. Changes passed lint and unit test checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3853 lint: lint legacy code with black | snapcraft | merged | Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%. | |
| #3852 lint: lint legacy code with isort | snapcraft | merged | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| #1745 static tests: upgrade to the newest flake8 | snapcraft | merged | Merged upgrade to the latest flake8 version, resolving all detected linting violations across nine files. The change passed CI checks and received reviewer approval. | |
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage. | |
| #5820 style: ignore legacy folder | snapcraft | merged | Merged a one-line config update to correctly ignore the legacy folder in linting rules. This prevents false positive ruff errors on legacy code. Approved by two reviewers and merged after passing CI checks. | |
| #3621 setup: unpin linters and add additional linting tools | snapcraft | merged | Merged changes unpinning legacy linters like mypy and flake8, adding pyright and isort for the updated codebase. Approved by reviewers, passed CI, and integrated without coverage changes. |