← Back to issue list

lint: lint legacy code with flake8

View original Github issue

Metadata

Project
snapcraft
Number
#3854
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3854 (commit 60884d4) applying flake8 lint fixes to 17 snapcraft_legacy files, part of the legacy-code lint sweep alongside #3852 (isort), #3853/#3865 (black).

Resolution: closed resolved

Reason: PR #3854 was approved and merged into main as commit 60884d4e2, changing 17 files with flake8 cleanups (+31/-36). No functional behaviour change; coverage stayed at 88.16% per the Codecov report.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- lint legacy code with flake8

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3854 (commit 60884d4) applying flake8 lint fixes to 17 snapcraft_legacy files, part of the legacy-code lint sweep alongside #3852 (isort), #3853/#3865 (black).
stealth/space-bunny-alpha — closed resolved Merged #3854 as commit 60884d4, applying flake8 linting fixes to 17 legacy files; coverage was unchanged.
qwen/qwen3.6-35b-a3b — — Merged into main following approval and passing CI. The change applies flake8 linting to legacy code across 17 files, modifying 31 additions and 36 deletions. Code coverage remains unchanged.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Applied flake8 linting to legacy code. Code coverage remained unchanged at 88.16%. Integrated by maintainer mr-cal.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3852 (confidence 88%)

    Sibling PR 'lint: lint legacy code with isort' merged as 38b9b7d3 in the same legacy linting series.

  • Related To: canonical/snapcraft#3853 (confidence 85%)

    Sibling PR 'lint: lint legacy code with black' merged as 806bfd04, targeting the same legacy code.

  • Related To: canonical/snapcraft#3865 (confidence 75%)

    Follow-up black linting of legacy code merged as c34b9478.

  • Superseded By: canonical/snapcraft#4012 (confidence 55%)

    Later PR migrating linters from flake8 to ruff, which ultimately replaced this flake8 configuration.

Related issues

Issue Project State Summary Similarity
#3852 lint: lint legacy code with isort snapcraft merged Merged PR #3852 as commit 38b9b7d34, re-enabling isort linting for legacy code.
78%
#3853 lint: lint legacy code with black snapcraft merged Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
76%
#3865 lint: lint legacy code with black snapcraft merged Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04).
72%