lint: lint legacy code with isort
Metadata
Current evaluation
Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Re-enable `isort` for legacy code.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to re-enable isort for legacy code. Passes lint and unit tests with no coverage impact, standardizing import sorting across the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Re-enables isort linting for legacy code. The commit passes all checks and maintains existing code coverage without altering test results. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3854 lint: lint legacy code with flake8 | snapcraft | merged | Merged into main following approval and passing CI. The change applies flake8 linting to legacy code across 17 files, modifying 31 additions and 36 deletions. Code coverage remains unchanged. | |
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage. | |
| #3853 lint: lint legacy code with black | snapcraft | merged | Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%. | |
| #3621 setup: unpin linters and add additional linting tools | snapcraft | merged | Merged changes unpinning legacy linters like mypy and flake8, adding pyright and isort for the updated codebase. Approved by reviewers, passed CI, and integrated without coverage changes. | |
| #5820 style: ignore legacy folder | snapcraft | merged | Merged a one-line config update to correctly ignore the legacy folder in linting rules. This prevents false positive ruff errors on legacy code. Approved by two reviewers and merged after passing CI checks. | |
| #36 Lint | imagecraft | merged | Merged a single-file linting adjustment with one addition and one deletion. The maintainer-submitted change required no reviews or CI checks before integration. |