lint: lint legacy code with isort
Metadata
Current evaluation
Merged PR #3852 as commit 38b9b7d34, re-enabling isort linting for legacy code.
Resolution: closed resolved
Reason: PR #3852 was approved and merged into main as 38b9b7d34. It restored isort checks for legacy code, with no change to test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Re-enable `isort` for legacy code.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3852 as commit 38b9b7d34, re-enabling isort linting for legacy code. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3852 was merged into main, re-enabling isort linting for legacy code. The change was approved and produced no coverage impact. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to re-enable isort for legacy code. Passes lint and unit tests with no coverage impact, standardizing import sorting across the codebase. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3383
(confidence 78%)
Earlier merged isort cleanup sorted imports across the remaining Python files, providing groundwork for lint enforcement.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3854 lint: lint legacy code with flake8 | snapcraft | merged | Merged PR #3854 (commit 60884d4) applying flake8 lint fixes to 17 snapcraft_legacy files, part of the legacy-code lint sweep alongside #3852 (isort), #3853/#3865 (black). | |
| #3853 lint: lint legacy code with black | snapcraft | merged | Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting. | |
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04). |