lint: lint legacy code with black
Metadata
Current evaluation
Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
The previous PR https://github.com/snapcore/snapcraft/pull/3853 added legacy code to the `make` command `autoformat-black`, but not to `test-black`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add legacy code to the make test-black command, aligning it with make autoformat-black. Approved and merged with no impact on code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added legacy code to the make test-black linting command, correcting an omission from a prior PR. Coverage remains unchanged, standardizing formatting checks for legacy code. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3853 lint: lint legacy code with black | snapcraft | merged | Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%. | |
| #3650 lint: apply autoformat-black to source files | snapcraft | merged | Merged following maintainer approval and passing CI. The update modifies the lint configuration to apply autoformat-black exclusively to source files, aligning it with test-black behavior. | |
| #3787 lint: apply black to parts directories | snapcraft | merged | Applied Black formatting to previously ignored snapcraft/parts/ and tests/unit/parts/ directories. Merged after reviewer approval and passing CI checks, with no impact on overall code coverage. | |
| #2599 static: update to newer black | snapcraft | merged | Merged after reviewer approval and passing CI. Updated the codebase to a newer Black formatter version across 15 files (+35/-41 lines). Codecov reported 85.71% diff coverage, flagging a missing base commit upload. | |
| #3852 lint: lint legacy code with isort | snapcraft | merged | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| #2603 black: minor format changes from updated black | snapcraft | merged | Minor formatting updates from the updated black code formatter were reviewed, approved, passed CI checks, and successfully merged into the main branch. | |
| #3722 static: black update to 22 syntax | snapcraft | merged | Merged update to Black formatter v22 syntax across 55 files. Approved by reviewer, passed CI, and integrated into main despite a minor 0.08% coverage decrease. | |
| #1960 style(lint): move from black to ruff | charmcraft | merged | Merged after two approvals and passing CI. Replaced Black with Ruff across 122 files, updating 1778 lines and removing 557 to modernize the linting configuration. | |
| #4067 lint: ignore files in .gitignore for black | snapcraft | merged | Merged changes to update Black linting configuration, replacing exclude with extend-exclude to properly respect .gitignore files. Exclusions for prime/ and stage/ are now limited to the project root. Coverage unchanged. | |
| #2180 code: use black as the standard style | snapcraft | merged | Merged after approval and CI checks. Adopted Black as the standard code formatter, reformatting 567 files with 39,831 additions and 33,762 deletions. Diff coverage reached 90.92%. |