lint: lint legacy code with black
Metadata
Current evaluation
Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04).
Resolution: closed resolved
Reason: The PR was merged into main (789e162, squashed as c34b94789 'lint: lint legacy code with black (#3865)'), aligning the `test-black` target with the `autoformat-black` file list introduced by #3853 (806bfd04).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
The previous PR https://github.com/snapcore/snapcraft/pull/3853 added legacy code to the `make` command `autoformat-black`, but not to `test-black`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3865 (789e162), adding legacy code to test-black so it matches autoformat-black from #3853. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add legacy code to the make test-black command, aligning it with make autoformat-black. Approved and merged with no impact on code coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#3853
(confidence 92%)
Preceding PR that added legacy code to `autoformat-black` but not `test-black`; this PR completes the lint coverage
-
Related To:
snapcore/snapcraft#3854
(confidence 55%)
Sibling 'lint: lint legacy code with flake8' commit 60884d4e2, part of the same legacy linting series
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3853 lint: lint legacy code with black | snapcraft | merged | Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting. | |
| #3650 lint: apply autoformat-black to source files | snapcraft | merged | Merged #3650 to scope autoformat-black to source files, matching test-black; landed in commit 0481269c4. | |
| #3787 lint: apply black to parts directories | snapcraft | merged | Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored. | |
| #2603 black: minor format changes from updated black | snapcraft | merged | Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing. | |
| #3854 lint: lint legacy code with flake8 | snapcraft | merged | Merged PR #3854 (commit 60884d4) applying flake8 lint fixes to 17 snapcraft_legacy files, part of the legacy-code lint sweep alongside #3852 (isort), #3853/#3865 (black). | |
| #2599 static: update to newer black | snapcraft | merged | Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56. | |
| #638 style: update to black 2024 | craft-parts | merged | Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627. | |
| #3852 lint: lint legacy code with isort | snapcraft | merged | Merged PR #3852 as commit 38b9b7d34, re-enabling isort linting for legacy code. |