tests: allow local git submodules
Metadata
Current evaluation
Merged PR #3953 as commit 95de62207, adding protocol.file.allow=always to test Git commands so Git 2.34.1 permits local submodules.
Resolution: closed resolved
Reason: PR #3953 was merged into main as commit 95de62207. It enabled local-file Git submodule operations required by Git 2.34.1.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
git v2.34.1 requires the config `protocol.file.allow=always` when adding a local submodule
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3953 as commit 95de62207, adding protocol.file.allow=always to test Git commands so Git 2.34.1 permits local submodules. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3953, updating test Git commands with protocol.file.allow=always for local submodules on Git 2.34.1. The equivalent craft-parts fix landed in #309. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding protocol.file.allow=always configuration to support local git submodules in tests, ensuring compatibility with git v2.34.1 and newer. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve Git v2.34.1 compatibility by adding protocol.file.allow=always, enabling local git submodules in tests. Integrated into main without coverage changes. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#309
(confidence 100%)
Equivalent fix merged in craft-parts commit a7dfeafbbe72acc8a4c7d48ed9fb9de1ca61b59c.
-
Related To:
canonical/snapcraft#3979
(confidence 90%)
A later merged PR applied the same local-submodule test change in commit 5680eb7c5.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3979 tests: allow local git submodules | snapcraft | merged | Merged PR #3979 as commit 5680eb7c5, allowing local submodules in tests by setting Git's protocol.file.allow=always for Git 2.34.1. | |
| #327 tests: backport git submodule test fix | craft-parts | merged | Merged #327 backported #309/a7dfeafb, fixing the Git source test by allowing local file-protocol submodules in repositories created by the test suite. | |
| #309 tests: re-enable git submodule test | craft-parts | merged | Merged in craft-parts#309 (commit a7dfeafb), re-enabling the Git submodule test with -c protocol.file.allow=always for test-created repositories. |