← Back to issue list

tests: allow local git submodules

View original Github issue

Metadata

Project
snapcraft
Number
#3979
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3979 as commit 5680eb7c5, allowing local submodules in tests by setting Git's protocol.file.allow=always for Git 2.34.1.

Resolution: closed resolved

Reason: PR #3979 was merged as commit 5680eb7c5. The change sets protocol.file.allow=always so tests can add local submodules under Git 2.34.1.

Evaluated by: mr-cal-bot

No scores available.

Issue body

git v2.34.1 requires the config `protocol.file.allow=always` when adding a local submodule Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3979 as commit 5680eb7c5, allowing local submodules in tests by setting Git's protocol.file.allow=always for Git 2.34.1.
stealth/space-bunny-alpha — closed resolved Merged test configuration setting Git's protocol.file.allow=always, allowing local submodules with Git 2.34.1 and restoring submodule-test compatibility.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Updates test configuration to set protocol.file.allow=always, enabling local git submodules required by git v2.34.1+. Changes span one file with 13 additions and 2 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Configures tests to set protocol.file.allow=always, enabling local git submodules and satisfying git v2.34.1 requirements. Co-authored by Sergio Schvezov.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3953 (confidence 95%)

    Merged equivalent change applying the same Git configuration to local submodules.

Related issues

Issue Project State Summary Similarity
#3953 tests: allow local git submodules snapcraft merged Merged PR #3953 as commit 95de62207, adding protocol.file.allow=always to test Git commands so Git 2.34.1 permits local submodules.
96%
#327 tests: backport git submodule test fix craft-parts merged Merged #327 backported #309/a7dfeafb, fixing the Git source test by allowing local file-protocol submodules in repositories created by the test suite.
78%
#309 tests: re-enable git submodule test craft-parts merged Merged in craft-parts#309 (commit a7dfeafb), re-enabling the Git submodule test with -c protocol.file.allow=always for test-created repositories.
73%