← Back to issue list

{kbuild,kernel} plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2368
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791.

Resolution: closed resolved

Reason: PR #2368 was merged with commit ddbda36b5, implementing base-aware behavior for the KBuild and Kernel plugins.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1794790](https://bugs.launchpad.net/snapcraft/+bug/1794790) and [LP: #1794791](https://bugs.launchpad.net/snapcraft/+bug/1794791) by updating the KBuild plugin (and the Kernel plugin, which inherits from it) to support bases, specifically core16 and core18.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791.
stealth/space-bunny-alpha — closed resolved Merged #2368, adding core16 and core18 base support to the KBuild and inherited Kernel plugins, resolving LP bugs #1794790 and #1794791.
qwen/qwen3.6-35b-a3b — — Merged after review and CI approval, adding core16 and core18 base support to the KBuild and Kernel plugins. Resolved Launchpad bugs #1794790 and #1794791 across 7 files with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates the KBuild and Kernel plugins to support core16 and core18 bases, resolving Launchpad bugs #1794790 and #1794791. Achieved 100% diff coverage.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1794790 Update the kbuild plugin to be base aware snapcraft (launchpad) closed Closed by kyrofa pointing to snapcore/snapcraft PR #2368, merged as commit ddbda36b5 "{kbuild,kernel} plugin: add support for bases", adding core16/core18 base support to the kbuild plugin (plus its inheriting kernel plugin).
85%
#1794791 Update the kernel plugin to be base aware snapcraft (launchpad) closed Kernel and KBuild plugins gained base support via merged PR snapcore/snapcraft#2368 (commit ddbda36b5).
78%
#2372 gradle plugin: add support for bases snapcraft merged Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18.
76%
#2373 rust plugin: add support for bases snapcraft merged Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
76%
#2363 {make,cmake,autotools} plugin: add support for bases snapcraft merged Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93.
75%
#2357 scons plugin: add support for bases snapcraft merged Merged #2357, making the Scons plugin base-aware for core16/core18; landed as commit 883c308c9 and resolved LP #1794801.
74%
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
74%
#2362 python plugin: add support for bases snapcraft merged Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread.
73%
#2364 maven plugin: add support for bases snapcraft merged PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345).
73%
#2366 qmake plugin: add support for bases snapcraft merged Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799.
73%