← Back to issue list

Plugins: Enable qmake for core22

View original Github issue

Metadata

Project
snapcraft
Number
#4162
Type
pull request
State
merged
Author
ScarlettGatelyMoore
Labels
—
Created
Updated
Closed

Current evaluation

PR merged as d2731f1a8 ("feat(plugin): enable qmake for core22") after the qmake plugin was upstreamed to craft-parts via canonical/craft-parts#463 (commit 641edb59) and released in craft-parts 1.27.0.

Resolution: closed resolved

Reason: The PR was merged into snapcraft main as commit d2731f1a8. Following @lengau's review, the Python plugin code was moved upstream to canonical/craft-parts#463, released in craft-parts 1.27.0, unblocking this PR which then merged carrying the spread tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR merged as d2731f1a8 ("feat(plugin): enable qmake for core22") after the qmake plugin was upstreamed to craft-parts via canonical/craft-parts#463 (commit 641edb59) and released in craft-parts 1.27.0.
stealth/space-bunny-alpha — closed resolved Merged #4162 as d2731f1a8, enabling qmake for core22 through craft-parts, with upstream support released in craft-parts 1.27.0.
qwen/qwen3.6-35b-a3b — — Merged after relocating the qmake plugin logic upstream to craft-parts. The change retained snapcraft spread tests, enabling qmake support for core22 upon the craft-parts 1.27 release.
qwen3.6-35b-a3b-mtp-q6 — — Merged after the qmake plugin was upstreamed to craft-parts. This PR retains the spread tests to validate core22 support, finalizing the integration following the craft-parts 1.27 release.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#463 (confidence 95%)

    Upstream qmake plugin implementation (commit 641edb59) that this PR's core22 support depends on, released in craft-parts 1.27.0.

  • Superseded By: canonical/craft-parts#463 (confidence 90%)

    Maintainer asked that the Python plugin code move upstream to craft-parts; snapcraft PR kept only the spread tests.

  • Related To: canonical/snapcraft#3391 (confidence 60%)

    Earlier snapcraft PR porting the qmake plugin for plugins v2.

Related issues

Issue Project State Summary Similarity
#463 plugins: qmake craft-parts merged Merged qmake plugin support in PR #463 as commit 641edb59; the plugin shipped in craft-parts 1.27.0.
84%
#184 plugins: cmake craft-parts merged Merged the CMake plugin port into craft-parts via PR #184, merge commit 57744f7a, with implementation commit 9ceb1fc8.
71%
#2366 qmake plugin: add support for bases snapcraft merged Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799.
71%