← Back to issue list

fix(linter-ros2-humble-mixed): change expected output since new pytho…

View original Github issue

Metadata

Project
snapcraft
Number
#4184
Type
pull request
State
merged
Author
Guillaumebeuzeboc
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4184 as commit 673e5ca53, updating the ROS 2 Humble mixed spread test’s expected output for newer Python library output.

Resolution: closed resolved

Reason: The approved PR was merged into the 7.4 hotfix branch as commit 673e5ca53. Its change updates the colcon ROS 2 linter test expectation after the Python library output changed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

change expected output since new python lib - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4184 as commit 673e5ca53, updating the ROS 2 Humble mixed spread test’s expected output for newer Python library output.
stealth/space-bunny-alpha — closed resolved PR #4184 (Guillaumebeuzeboc) merged into hotfix/7.4 as 673e5ca53, updating the expected colcon-ros2-linter output for the linter-ros2-humble-mixed test to match a newer Python library.
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.4 as 673e5ca53; updated expected colcon-ros2-linter output to match a newer Python library.
qwen/qwen3.6-35b-a3b — — Merged to hotfix/7.4. Updated expected test output to resolve a colcon-ros2-linter failure caused by a new Python library. The change passed CI, received approval, and modified one file. An unrelated flutter test failure was noted.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.4. Updated expected linter output to accommodate a new Python library, resolving a colcon-ros2-linter test failure. Unrelated flutter test failures remain.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#4113 (confidence 90%)

    Earlier merged PR updated the same linter-ros2-humble-mixed spread test expectations.

Related issues

Issue Project State Summary Similarity
#4113 tests: update linter-ros2-humble-mixed spread test snapcraft merged Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed.
82%
#4223 ros: make linter tests more flexible snapcraft merged Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures.
78%
#4369 test(spread): make ros linter test less strict snapcraft merged Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256.
72%