tests: update linter-ros2-humble-mixed spread test
Metadata
Current evaluation
Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed.
Resolution: closed resolved
Reason: PR #4113 was approved and merged into main as 2735e2c3c, with PR head 8ad010f, restoring stability to the affected spread test.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Some of the libraries from the ros2 humble extension were removed and [broke a spread test](https://github.com/snapcore/snapcraft/actions/runs/4788448057/jobs/8535139618?pr=4111).
Hopefully, this is an uncommon event. If it continues to occur, we may need to consider a different approach to this spread test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4113 as commit 2735e2c3c, removing seven obsolete checks from the ROS 2 Humble mixed spread test after extension libraries disappeared. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged test-only fix (commit 2735e2c3c): dropped 7 lines of library-name assertions from the linter-ros2-humble-mixed spread task.yaml after upstream ros2-humble libraries changed and broke CI in #4111. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4113 at 8ad010f, removing seven outdated lines from the ROS 2 Humble mixed spread test after extension libraries were removed, restoring test stability. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated the linter-ros2-humble-mixed spread test to accommodate removed ROS2 libraries that caused failures. Codecov reported no coverage impact upon merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256. | |
| #4223 ros: make linter tests more flexible | snapcraft | merged | Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures. | |
| #4184 fix(linter-ros2-humble-mixed): change expected output since new pytho… | snapcraft | merged | Merged #4184 as commit 673e5ca53, updating the ROS 2 Humble mixed spread test’s expected output for newer Python library output. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged PR #4595 (commit 043584583) removing Core 24 ROS 2 extension linter spread tests from five files, since ROS for 24.04 and its extension do not exist. Approved by 2 reviewers. | |
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations. | |
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged #4212 (13071d7a0), reverting d48db220 from #4202 and restoring seven ROS linter-warning expectations in spread tests. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged. | |
| #5296 Change ROS spread testing strategy | snapcraft | closed | ROS spread-test CI strategy was updated in merged PR #5418 (commit a5682c276) to reduce test-suite duration. |