tests: update linter-ros2-humble-mixed spread test
Metadata
Current evaluation
Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Some of the libraries from the ros2 humble extension were removed and [broke a spread test](https://github.com/snapcore/snapcraft/actions/runs/4788448057/jobs/8535139618?pr=4111).
Hopefully, this is an uncommon event. If it continues to occur, we may need to consider a different approach to this spread test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated the linter-ros2-humble-mixed spread test to accommodate removed ROS2 libraries that caused failures. Codecov reported no coverage impact upon merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an update to the linter-ros2-humble-mixed spread test, resolving failures caused by removed ROS2 humble extension libraries. Integrated into main with no coverage change. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4223 ros: make linter tests more flexible | snapcraft | merged | Merged changes to make ROS linter tests more flexible, resolving flaky failures in the linter-ros2-humble-mixed spread test caused by fluctuating unused library lists. Approved and passed CI. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files. | |
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file. | |
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged to restore linter warnings to spread tests by reverting commit d48db22. Approved by one reviewer, passed CI, and modified one file (+7/-0) without impacting code coverage. | |
| #4184 fix(linter-ros2-humble-mixed): change expected output since new pytho… | snapcraft | merged | Merged to hotfix/7.4. Updated expected test output to resolve a colcon-ros2-linter failure caused by a new Python library. The change passed CI, received approval, and modified one file. An unrelated flutter test failure was noted. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged removal of generator warnings from ROS linter spread tests. Contributors traced warnings to upstream ROS library updates, not linter changes. The update deletes seven lines, passed CI, and merged with no coverage impact. | |
| #3662 tests: update spread url | snapcraft | merged | Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage. |