test(spread): make ros linter test less strict
Metadata
Current evaluation
Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
This spread test is now less strict but still verifies that:
1. `libpng` library warning is filtered
2. `ros2-humble` library warnings are not filtered
Fixes #4256
(CRAFT-1872)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to main. Relaxed the ROS linter spread test while maintaining verification for libpng warning filtering and ros2-humble warning retention. Resolves #4256. Codecov notes a 0.03% coverage decrease. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Relaxed the ROS linter spread test to reduce false positives while preserving verification for libpng warning filtering and ros2-humble warnings. Resolves #4256. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4223 ros: make linter tests more flexible | snapcraft | merged | Merged changes to make ROS linter tests more flexible, resolving flaky failures in the linter-ros2-humble-mixed spread test caused by fluctuating unused library lists. Approved and passed CI. | |
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability. | |
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file. | |
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged to restore linter warnings to spread tests by reverting commit d48db22. Approved by one reviewer, passed CI, and modified one file (+7/-0) without impacting code coverage. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged removal of generator warnings from ROS linter spread tests. Contributors traced warnings to upstream ROS library updates, not linter changes. The update deletes seven lines, passed CI, and merged with no coverage impact. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback. | |
| #5296 Change ROS spread testing strategy | snapcraft | closed | Abandoned without implementation. The proposal to restrict ROS spread tests to ROS-specific changes or weekly runs was closed, leaving CI optimization unaddressed. No resolution or merge details were provided. |