← Back to issue list

test(spread): make ros linter test less strict

View original Github issue

Metadata

Project
snapcraft
Number
#4369
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256.

Resolution: closed resolved

Reason: PR #4369 was merged as commit 8d0c451a4. It relaxed exact ROS linter-output matching while preserving assertions that libpng is filtered and ros2-humble warnings are not, resolving #4256.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- This spread test is now less strict but still verifies that: 1. `libpng` library warning is filtered 2. `ros2-humble` library warnings are not filtered Fixes #4256 (CRAFT-1872)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256.
stealth/space-bunny-alpha — closed resolved PR #4369 (mr-cal, CRAFT-1872) merged to main (1ae07ec), relaxing the ROS spread linter test to only assert libpng warnings are filtered and ros2-humble unused-library warnings are not; fixes issue #4256.
stealth/space-bunny-alpha — closed resolved PR #4369 by mr-cal merged (commit 8d0c451a4) into main, relaxing the ROS linter spread test to assert only that the libpng warning is filtered and ros2-humble warnings are not, closing #4256 (CRAFT-1872).
stealth/space-bunny-alpha — closed resolved PR #4369 merged as commit 8d0c451a4 (CRAFT-1872), relaxing the ROS spread linter test while still asserting libpng warnings are filtered and ros2-humble unused-library warnings remain. Closes #4256.
stealth/space-bunny-alpha — closed resolved Merged PR #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; closes #4256.
qwen/qwen3.6-35b-a3b — — Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256.
qwen3.6-35b-a3b-mtp-q6 — — Merged to main. Relaxed the ROS linter spread test while maintaining verification for libpng warning filtering and ros2-humble warning retention. Resolves #4256. Codecov notes a 0.03% coverage decrease.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4256 (confidence 100%)

    This issue requested the improved ROS library-linter check implemented by PR #4369.

Related issues

Issue Project State Summary Similarity
#4113 tests: update linter-ros2-humble-mixed spread test snapcraft merged Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed.
85%
#4223 ros: make linter tests more flexible snapcraft merged Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures.
82%
#4203 ros: remove linter warnings from spread tests snapcraft merged Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations.
80%
#4202 ros: remove generator warnings from linter spread tests snapcraft merged Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged.
76%
#4212 Revert "ros: remove linter warnings from spread tests (#4202)" snapcraft merged Merged #4212 (13071d7a0), reverting d48db220 from #4202 and restoring seven ROS linter-warning expectations in spread tests.
76%
#4595 tests(spread): remove core24 ros2 extension linter tests snapcraft merged Merged PR #4595 (commit 043584583) removing Core 24 ROS 2 extension linter spread tests from five files, since ROS for 24.04 and its extension do not exist. Approved by 2 reviewers.
76%
#5296 Change ROS spread testing strategy snapcraft closed ROS spread-test CI strategy was updated in merged PR #5418 (commit a5682c276) to reduce test-suite duration.
73%
#4256 Improve check for library linter in the ROS tests snapcraft closed Resolved by PR #4369 (commit 8d0c451a4), which made ROS linter tests validate warning patterns instead of exact output.
72%
#4184 fix(linter-ros2-humble-mixed): change expected output since new pytho… snapcraft merged Merged #4184 as commit 673e5ca53, updating the ROS 2 Humble mixed spread test’s expected output for newer Python library output.
72%
#1366 tests(spread): make release test less flaky charmcraft merged Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362.
71%