ros: make linter tests more flexible
Metadata
Current evaluation
Merged changes to make ROS linter tests more flexible, resolving flaky failures in the linter-ros2-humble-mixed spread test caused by fluctuating unused library lists. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Adds some flexibility to the `linter-ros2-humble-mixed` spread test, which has been failing due to a set of 7 libraries appearing and disappearing from the list of unused libraries:
- https://github.com/snapcore/snapcraft/pull/4113
- https://github.com/snapcore/snapcraft/pull/4184
- https://github.com/snapcore/snapcraft/pull/4202
- https://github.com/snapcore/snapcraft/pull/4212
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to make ROS linter tests more flexible, resolving flaky failures in the linter-ros2-humble-mixed spread test caused by fluctuating unused library lists. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated the ROS linter spread test to accommodate fluctuating unused library lists, resolving recurring CI failures. Code coverage remained unchanged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to make ROS linter tests more flexible, resolving flaky failures from libraries appearing and disappearing in the unused libraries list. Successfully integrated into main without coverage impact. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256. | |
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged removal of generator warnings from ROS linter spread tests. Contributors traced warnings to upstream ROS library updates, not linter changes. The update deletes seven lines, passed CI, and merged with no coverage impact. | |
| #4184 fix(linter-ros2-humble-mixed): change expected output since new pytho… | snapcraft | merged | Merged to hotfix/7.4. Updated expected test output to resolve a colcon-ros2-linter failure caused by a new Python library. The change passed CI, received approval, and modified one file. An unrelated flutter test failure was noted. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files. | |
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged to restore linter warnings to spread tests by reverting commit d48db22. Approved by one reviewer, passed CI, and modified one file (+7/-0) without impacting code coverage. | |
| #4828 Add ROS 2 Jazzy content-sharing support | snapcraft | merged | Added ROS 2 Jazzy content-sharing support. Merged after approval by two reviewers and passing CI checks. Changes span 13 files (+627/-18). Author noted unrelated failing spread tests. | |
| #3536 ROS plugins v2 misc fixes | snapcraft | merged | Merged. Fixes ROS plugins v2 staging failures by checking local ROS directories and skipping rosdep resolution for locally available packages. Updated tests for core20. Approved by two reviewers and passed CI. | |
| #4256 Improve check for library linter in the ROS tests | snapcraft | closed | Closed without implementation. The proposed resolution involves using regex-based pattern matching to relax strict linter checks and accommodate frequent ROS library changes. |