ros: make linter tests more flexible
Metadata
Current evaluation
Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures.
Resolution: closed resolved
Reason: The approved PR was merged into main as 64c8f1e87. It relaxed the linter-ros2-humble-mixed spread test after repeated failures caused by libraries appearing and disappearing from the unused-library list.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Adds some flexibility to the `linter-ros2-humble-mixed` spread test, which has been failing due to a set of 7 libraries appearing and disappearing from the list of unused libraries:
- https://github.com/snapcore/snapcraft/pull/4113
- https://github.com/snapcore/snapcraft/pull/4184
- https://github.com/snapcore/snapcraft/pull/4202
- https://github.com/snapcore/snapcraft/pull/4212
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4223 as commit 64c8f1e87, making the ROS 2 Humble mixed linter spread test tolerate changing unused-library warnings. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4223 (64c8f1e87), making the ROS 2 Humble mixed linter spread test tolerate changing unused-library lists and avoid flaky failures. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed spread linter test tolerate changing unused-library lists and prevent flaky failures. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4223 (commit 64c8f1e87), making the linter-ros2-humble-mixed spread test more flexible and resilient to changing unused-library lists. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to make ROS linter tests more flexible, resolving flaky failures in the linter-ros2-humble-mixed spread test caused by fluctuating unused library lists. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated the ROS linter spread test to accommodate fluctuating unused library lists, resolving recurring CI failures. Code coverage remained unchanged. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4113
(confidence 100%)
Prior update to the same linter spread test, cited as one of the recurring unused-library-list failures.
-
Related To:
snapcraft#4184
(confidence 100%)
Earlier related adjustment to the ROS2 Humble mixed linter test.
-
Related To:
snapcraft#4202
(confidence 100%)
Earlier related adjustment to the ROS2 Humble mixed linter test.
-
Related To:
snapcraft#4212
(confidence 100%)
Earlier related adjustment to the ROS2 Humble mixed linter test.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256. | |
| #4184 fix(linter-ros2-humble-mixed): change expected output since new pytho… | snapcraft | merged | Merged #4184 as commit 673e5ca53, updating the ROS 2 Humble mixed spread test’s expected output for newer Python library output. | |
| #4256 Improve check for library linter in the ROS tests | snapcraft | closed | Resolved by PR #4369 (commit 8d0c451a4), which made ROS linter tests validate warning patterns instead of exact output. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged. | |
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations. |