← Back to issue list

store: add missing case for list-keys

View original Github issue

Metadata

Project
snapcraft
Number
#4229
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged. Its store list-keys fix was superseded by #4234 and shipped via merged PR #4245 (commit 1c44a58fc), which now displays system keys that exist but are not registered.

Resolution: closed superseded

Reason: PR #4229 was closed unmerged because the same change was reworked in #4234 and merged as #4245 (commit 1c44a58fc, into hotfix/7.5 for CRAFT-1804), adding the missing store list-keys case that shows available-but-unregistered keys.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Now displays keys that are available on the system but not registered. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged. Its store list-keys fix was superseded by #4234 and shipped via merged PR #4245 (commit 1c44a58fc), which now displays system keys that exist but are not registered.
stealth/space-bunny-alpha — closed superseded Closed unmerged; its unregistered-system-key handling for list-keys was superseded by #4234 and delivered by merged PR #4245 (commit 1c44a58fc).
qwen/qwen3.6-35b-a3b — — Closed without review comments or CI results. The update added a missing case to display unregistered system keys, changing two files (+115/-28 lines). No explicit merge or rejection status was recorded.
qwen3.6-35b-a3b-mtp-q6 — — Adding a missing case for list-keys to display unregistered system keys was closed without merge. Zero comments and no activity indicate the change was abandoned.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#4245 (confidence 95%)

    Merged PR carrying the identical change as commit 1c44a58fc into hotfix/7.5.

  • Superseded By: snapcraft#4234 (confidence 88%)

    Earlier PR with the same title/change; #4245 cherry-picked its fix and #4234 was closed.

Related issues

Issue Project State Summary Similarity
#4234 store: add missing case for list-keys snapcraft closed The missing store list-keys case was delivered through #4245, merged into hotfix/7.5 as 1c44a58fc; #4234 was then closed.
87%
#4230 store: add missing case for list-keys snapcraft closed PR closed unmerged: author could not push to snapcore branches, so the store list-keys fix (CRAFT-1804, LP#1996618) moved to #4234 and landed via merged PR #4245, commit 1c44a58fc on hotfix/7.5.
86%
#4245 store: add missing case for list-keys snapcraft merged Merged into hotfix/7.5 as 1c44a58fc, adding the missing store list-keys case for CRAFT-1804; it cherry-picked the fix from #4234.
82%