← Back to issue list

store: add missing case for list-keys

View original Github issue

Metadata

Project
snapcraft
Number
#4234
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

The missing store list-keys case was delivered through #4245, merged into hotfix/7.5 as 1c44a58fc; #4234 was then closed.

Resolution: closed resolved

Reason: PR #4245 cherry-picked the approved #4234 change and merged it into hotfix/7.5 as commit 1c44a58fc. A maintainer confirmed that the hotfix would later be merged back to main.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- https://bugs.launchpad.net/snapcraft/+bug/1996618 CRAFT-1804

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved The missing store list-keys case was delivered through #4245, merged into hotfix/7.5 as 1c44a58fc; #4234 was then closed.
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5 by #4245 (1c44a58fc), adding the missing list-keys case; the hotfix was intended to be merged back to main.
stealth/space-bunny-alpha — closed resolved Ported by #4245 and merged into hotfix/7.5 as 1c44a58fc, adding the missing store list-keys handling; maintainers noted it would later return to main.
stealth/space-bunny-alpha — closed superseded PR #4234 was superseded by #4245, which landed the missing list-keys case in hotfix/7.5 as commit 1c44a58fc.
stealth/space-bunny-alpha — closed resolved Merged to hotfix/7.5 via #4245 (1c44a58fc), adding the missing list-keys case; maintainers said the hotfix would later be merged back to main.
qwen/qwen3.6-35b-a3b — — Merged as a hotfix to resolve a missing list-keys case. Approved with passing CI and full coverage. The change will be integrated into the main branch later.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds a missing case for list-keys in the store module. Resolved a pyright linting issue via a workaround. Approved with 100% test coverage and integrated as a hotfix before final merge to main.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4245 (confidence 99%)

    Merged the missing list-keys handling into hotfix/7.5 in commit 1c44a58fc.

Related issues

Issue Project State Summary Similarity
#4245 store: add missing case for list-keys snapcraft merged Merged into hotfix/7.5 as 1c44a58fc, adding the missing store list-keys case for CRAFT-1804; it cherry-picked the fix from #4234.
93%
#4229 store: add missing case for list-keys snapcraft closed Closed unmerged. Its store list-keys fix was superseded by #4234 and shipped via merged PR #4245 (commit 1c44a58fc), which now displays system keys that exist but are not registered.
87%
#4230 store: add missing case for list-keys snapcraft closed PR closed unmerged: author could not push to snapcore branches, so the store list-keys fix (CRAFT-1804, LP#1996618) moved to #4234 and landed via merged PR #4245, commit 1c44a58fc on hotfix/7.5.
86%